Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Remove .ppd related logic and rely on CUPS to know how to print #94

Closed
wants to merge 1 commit into from

Conversation

eaon
Copy link
Contributor

@eaon eaon commented Jun 28, 2022

On bullseye lpadmin complains that using drivers directly is deprecated,
hence we go with the flow and preemptively make sure we don't run into
this problem in the future.

This leaves printer model checks in place, but simultaneously lowers the
bar to support more printers in the future.

The change was tested with a HP LaserJet Pro M404n but not a Brother
HL-L2320D

Fixes #93

Testing

Part 1

  • make test passes and the new test_get_unsupported_printer_uri is a reasonable replacement for the tests that were removed
  • (Cross reference) Continue with securedrop-debian-packaging#352

Part 2

  • Connect printer, to start sd-devices
  • Log into client, and attempt to print a document as before
  • Printing the document succeeds

On bullseye lpadmin complains that using drivers directly is deprecated,
hence we go with the flow and pre-emptively make sure we don't run into
this problem in the future.

This leaves printer model checks in place, but simultaneously lowers the
bar to support more printers in the future.

This change was tested with an HP LaserJet Pro M404n but *not* with the
Brother HL-L2320D
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1

  • make test passes and the new test_get_unsupported_printer_uri is a reasonable replacement for the tests that were removed
  • (Cross reference) Continue with securedrop-debian-packaging#352

Part 2

  • Connect printer, to start sd-devices
  • Log into client, and attempt to print a document as before
  • ➖ Printing the document succeeds

    I am seeing issues with printing txt and image files. It can take somewhere around 5 minutes between when X Panel closes and one of these types of files is printed. They seem to print right away when I shutdown sd-devices. Doc and docx files print just fine the first time, but subsequent prints of doc and docx files never get printed. More testing is needed, but I think we should consider an alternative path where we go back to installing drivers since we're getting close to the release date.

@eaon
Copy link
Contributor Author

eaon commented Jun 29, 2022

Thanks @creviera, I'm glad that you caught that! Turns out that the drivers behave differently than the driver-less magic - using the drivers the printer behaves as expected, without I can reproduce your findings. I'm closing this PR in favour of opening a new one that will handle the lpadmin output in the same manner we handle the ppdc warning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lpadmin: Printer drivers are deprecated and will stop working in a future version of CUPS
2 participants