Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure StarToggleButton hover states honor offline status #936

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 13, 2020

Description

Fixes #935 .

Test Plan

  • Start the client and log in.
  • Confirm that you can star and unstar sources and the star icons behave.
  • Log out.
  • Confirm that you can not star or unstar sources, and that the star icons do not change, and there's no hover state suggesting they can.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

@rmol rmol force-pushed the 935-stop-offline-star-hover branch from 69d5b58 to d8067b9 Compare March 13, 2020 23:22
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sssoleileraaa sssoleileraaa merged commit 4f86a61 into master Mar 13, 2020
@sssoleileraaa sssoleileraaa deleted the 935-stop-offline-star-hover branch March 13, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When you start the client in offline mode unstarring still works
2 participants