When you start the client in offline mode unstarring still works

[sssoleileraaa]

STR

1. Make sure you have a starred source
2. Log into the client in offline mode
3. While offline, at any point during your session, click on the star to unstar the starred source

Expected

The "must sign in" message and for starring to not work

Actual

The "must sign in" message but starring does work

Note: This was happening on master before #933 was merged

[rmol]

I think this is going to be fixed by #916.

[sssoleileraaa]

Looks like it is not fixed by #916 sadly :(

[redshiftzero]

I just pulled latest master (7066e9b) and for me behavior is as expected both when I start the client in offline mode and I start the client in online mode and then logout

[eloquence]

I am also not able to reproduce this in a 0.2.3-deb prod build. I consistently get the "You must sign in" error.

[sssoleileraaa]

Oops I just realized that I get the "You must sign in" error but starred sources can still be unstarred. Lemme show a gif...

[sssoleileraaa]

[eloquence]

Not able to see this in the prod build, but let me try in master

[eloquence]

Yup, see the buggy behavior in master in Qubes.

[eloquence]

I can reproduce the broken behavior on commit b231971 (part of #872), but not before it.