Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When mousing over stars in offline mode, everything gets starred #938

Closed
eloquence opened this issue Mar 14, 2020 · 0 comments · Fixed by #941
Closed

When mousing over stars in offline mode, everything gets starred #938

eloquence opened this issue Mar 14, 2020 · 0 comments · Fixed by #941
Assignees
@rmol
Labels
bug Something isn't working

Comments

@eloquence
Copy link
Member

eloquence commented Mar 14, 2020 •
edited
Loading

#936 fixed #935, but it it introduced a new regression: you can now "paint" unstarred stars by mousing over them in offline mode.

STR

(Tested in latest master in Qubes)

  1. Launch client in offline mode with some submissions that don't have stars
  2. Mouse over those stars

Expected behavior

Sparkly hover effect but that's it

Actual behavior

Stars get painted blue for the duration of the session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmol rmol

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix StarToggleButton hover leave freedomofpress/securedrop-client
2 participants
@eloquence @rmol