Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversation refresh bugs 467, 463 #481

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Conversation

redshiftzero
Copy link
Contributor

Description

Fixes #467
Fixes #463

(medium term refactor in #473, this fix unblocks other development tasks for now)

Test Plan

  1. Log into client
  2. Create new source via source interface
  3. Refresh client and click on source
  4. Add message in source interface
  5. Refresh again, new message should appear
  6. Add message in source interface
  7. Star source
  8. New message should appear

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs, network (via the RPC service) traffic, or fine tuning of the graphical user interface, Qubes testing is required. Please check as applicable:

  • I have tested these changes in Qubes
  • I do not have a Qubes OS workstation (the reviewer will need to test these changes in Qubes)
  • Qt/UI changes only

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit 8fac972 into master Jul 19, 2019
@sssoleileraaa sssoleileraaa deleted the fix-conv-refresh branch July 19, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New messages not getting added to existing conversation Starring a source breaks message viewing
2 participants