Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starring a source breaks message viewing #463

Closed
sssoleileraaa opened this issue Jul 5, 2019 · 0 comments · Fixed by #481
Closed

Starring a source breaks message viewing #463

sssoleileraaa opened this issue Jul 5, 2019 · 0 comments · Fixed by #481
Assignees
@redshiftzero
Labels
bug Something isn't working
Milestone
0.2.0alpha

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Jul 5, 2019 •
edited
Loading

STR

  1. Send a message from a source
  2. Star that source in the client, see the "Downloading" message
  3. Click refresh icon

Expected Behavior

The message appears.

Actual Behavior

The message doesn't appear, but viewing the logs it's getting downloaded/decrypted.

This is related to #462. The message appears if you skip step 2 where you star a source.
@sssoleileraaa sssoleileraaa added the bug Something isn't working label Jul 5, 2019
@sssoleileraaa sssoleileraaa mentioned this issue Jul 5, 2019
Closed
@eloquence eloquence changed the title staring a source breaks message viewing Starring a source breaks message viewing Jul 8, 2019
@eloquence eloquence added this to the 0.2.0alpha milestone Jul 8, 2019
@sssoleileraaa sssoleileraaa mentioned this issue Jul 9, 2019
Closed
redshiftzero added a commit that referenced this issue Jul 18, 2019
@redshiftzero
app: redraw entire ConversationView when source is changed
23abcd1 
fix to #467 #463
redshiftzero added a commit that referenced this issue Jul 18, 2019
@redshiftzero
app: redraw entire ConversationView when source is changed
130d340 
fix to #467 #463
redshiftzero added a commit that referenced this issue Jul 18, 2019
@redshiftzero
app: redraw entire ConversationView when source is changed
bd765f6 
fix to #467 #463
@redshiftzero redshiftzero mentioned this issue Jul 18, 2019
Merged
3 tasks
@redshiftzero redshiftzero self-assigned this Jul 18, 2019
sssoleileraaa pushed a commit that referenced this issue Jul 19, 2019
@redshiftzero @sssoleileraaa
app: redraw entire ConversationView when source is changed
aa85f83 
fix to #467 #463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0alpha
Development

Successfully merging a pull request may close this issue.

Fix conversation refresh bugs 467, 463 freedomofpress/securedrop-client
3 participants
@eloquence @sssoleileraaa @redshiftzero