-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show/hide conversation items #473
Labels
♻️ Refactoring
This PR is a strict refactoring.
Comments
This is follow-up for #467 |
3 tasks
Here's a first proposal for the logic here:
Note that the part that complicates the issue here is the fact that items may be reordered - since the client will update to reflect the ordering on the server. |
This was referenced Dec 10, 2019
This was referenced Jan 8, 2020
ntoll
added a commit
to ntoll/securedrop-client
that referenced
this issue
Jan 9, 2020
ntoll
added a commit
to ntoll/securedrop-client
that referenced
this issue
Jan 29, 2020
sssoleileraaa
pushed a commit
that referenced
this issue
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Right now we create a conversation when a source is selected and we delete it whenever the source is unselected. If there is a sync and new messages in the conversation, we delete and recreate it.
Instead of deleting the conversation whenever the source is unselected, let's hide the conversation. And instead of recreating the conversation when new messages come in for a source, let's just append new message widgets to the conversation view.
The text was updated successfully, but these errors were encountered: