Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer trigger sync when files are missing #670

Closed
sssoleileraaa opened this issue Dec 18, 2019 · 2 comments · Fixed by #724
Closed

No longer trigger sync when files are missing #670

sssoleileraaa opened this issue Dec 18, 2019 · 2 comments · Fixed by #724

Comments

@sssoleileraaa
Copy link
Contributor

Description

Remove the areas of the code that sync with the server when a file is unexpectedly missing, e.g.

if not self.downloaded_file_exists(file.uuid):
self.sync_api()
return

Instead of waiting until a sync to update missing files so that they can be redownloaded by a user, do this immediately:

storage.update_missing_files(self.data_dir, self.session)

@eloquence
Copy link
Member

Per discussion at sprint planning today, this is blocked by completion of #473; it may make sense to wait until #288 is completed, as well.

@ntoll
Copy link
Contributor

ntoll commented Jan 20, 2020

Hi, I'm blocked on starting this until my outstanding PR's relating to the two issues mentioned by @eloquence are merged. Happy to pick this up once they're merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants