Elide source designation at lower window widths

[eloquence]

Resolves #1120

Status

Ready for review

Description

Elides the source designation if needed as the window is resized, while allocating a fixed width to the label to ensure that layout is not disrupted.

Testing

• Test resizing the window on Qubes for multiple sources to ensure it behaves as shown in the GIF animation below.
• Test switching to offline mode and back to online mode to ensure no regression in the placeholder display.
• Test sending replies from multiple sources to ensure no regression in placeholder hide/show behavior.

Checklist

• No update to the AppArmor profile is required for these changes
• No database schema changes are needed

[eloquence]

OK, this was pretty painful to debug, but it seems like the best way to avoid layout problems while resizing the window is to allocate a generous fixed width to the label while its actual contents change. That way Qt won't attempt to reflow the composite placeholder widget in sometimes broken ways.

Now to test this in Qubes!

[eloquence]

In my testing resize behavior is correct in Qubes :)

[eloquence]

test-buster fail is due to coverage. I would appreciate a first pass on the implementation -- does this approach make sense, or is there a simpler, more resilient or more Qt-y way to do this? If the approach is sound, will add required tests.

[sssoleileraaa]

did a first pass on your implementation and agree with your approach on changing max_length based on window size. all you need is test coverage and i'd say this is good to go in. let me know if you'd like help on writing the tests.

[sssoleileraaa]

yup, setting max_length here will turn on elided text

[sssoleileraaa]

hooking into the resize event works as expected

[eloquence]

Awesome, thanks for the review @creviera! :) We're at 100% coverage now and the test verifies the basic behavior implemented here. Please let me know if it's consistent with our approach to testing these widgets, happy to tweak.

[sssoleileraaa]

🚀