Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some source designations are truncated, bleed into placeholder text #1218

Open
eloquence opened this issue Feb 5, 2021 · 3 comments
Open
Labels
bug Something isn't working needs/reproducing

Comments

@eloquence
Copy link
Member

eloquence commented Feb 5, 2021

Tested in 0.4.0-dev-20210204-154420 on Qubes

STR

  1. Connect to a SecureDrop server with a significant number of sources (~50) so you see a large variety of source designations.
  2. Cycle through the sources and observe the reply placeholder text ("Compose a reply to ..")

Expected behavior

Placeholders are displayed in full, or elided as implemented in #1145

Actual behavior

Placeholders are truncated mid-word, and sometimes bleed into the "Compose a reply" text.

Screenshot

This screenshot shows a designation that is both truncated on the right, and bleeds into the placeholder text on the left.

truncation

@eloquence eloquence added bug Something isn't working needs/reproducing labels Feb 5, 2021
@eloquence
Copy link
Member Author

Have so far not been able to reproduce on latest main in Ubuntu development environment, may not be visible outside Qubes. (I've tested it by assigning a very long source name in https://github.com/freedomofpress/securedrop-client/blob/main/securedrop_client/gui/widgets.py#L3533, which gets correctly elided on window resize).

@eloquence
Copy link
Member Author

Not seeing this issue in Qubes anymore either, not on latest nightly nor on main. Closing for now until another repro.

@eloquence eloquence reopened this Feb 19, 2021
@eloquence
Copy link
Member Author

eloquence commented Feb 19, 2021

I'm seeing the truncation issue more reliably in offline->online mode transitions (only tested in Qubes for now):

  1. Launch the app in offline mode
  2. Resize the window to the smallest possible size
  3. Select a source with a long name
  4. Click "Sign in" and complete the login

The reply placeholder for the selected source is now cut off for me, without eliding. I don't believe this is a recent regression -- I see the same issue on the 0.4.0 tag as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs/reproducing
Projects
None yet
Development

No branches or pull requests

1 participant