Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent event handler from being triggered twice #1220

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

eloquence
Copy link
Member

Description

Fixes #1217

Test Plan

Must be tested in Qubes or with local modifications, as clicking files in a development environment will have no effect.

  1. Run the SecureDrop client from this branch
  2. Connect to a server with file submissions
  3. Download a file submission and attempt to open it
  • Observe that only a single diposable VM is opened
  • Observe that print/export actions still start dialogs as expected
  1. Resize the client window to its minimum size
  2. Observe that Conversation View cut off when scaling down client #1061 and Resizable speech bubbles and file widgets #1204 are still fixed and that there are no regressions in resize behavior.

Checklist

  • I have tested these changes in the appropriate Qubes environment
  • No update to the AppArmor profile is required for these changes
  • No database schema changes are needed

@eloquence
Copy link
Member Author

In testing in Qubes all LGTM; I did observe #1218 again, but I believe that's unrelated and seems to occur also in the recent signed release.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and makes sense why this was triggering twice :)

@sssoleileraaa sssoleileraaa merged commit af881d7 into main Feb 19, 2021
@sssoleileraaa sssoleileraaa deleted the 1217-seeing-double branch February 19, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files are opened twice
2 participants