-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize reply placeholder width #1119
Comments
Unfortunately I don't see a simple way to avoid this issue. This screenshot illustrates the problem: The textbox takes up as much space as is available, and the placeholder text is a child object of the text box. The only reasonable solution I see is to try to force the placeholder text to float on top of the textbox, instead of having it be layouted as a child object. That may add too much complexity to be worthwhile, and eliding the placeholder text (#1120) seems to get us bigger bang for the buck. |
I'm also not keen on what looks like a tabled layout, with the airplane in its own column? (...she says, keenly watching the hardworking dev team hold it together as to not wither in tears of frustration after having spent scores of hours just trying to work within QTs constraints so that it does not implode) |
There are a few different strategies Allie and I have discussed for this, but for now we're deferring it in favor of #1120. It would still be nice to eventually solve to get those extra pixels, provided it doesn't add significant technical debt/complexity. |
With #1145 merged, upon consideration, I'd nominate to close this; the "..." abbreviation should give us enough space and looks sufficiently polished, IMO. |
Closing per above. |
This screenshot shows how, at a lower widow size (which will be supported once #1103 is merged), the "Compose a reply to" placeholder can be truncated for long source designations (the full codename is
organizational implementation
).We should elide those codenames (#1120), but we should also optimize the width of the placeholder, which appears to currently be cut off where the "Send" button begins, even though it is always rendered above it.
The text was updated successfully, but these errors were encountered: