Panics not caught in a nested contracts

[delaaxe]

Which component is your bug related to?

snforge

Foundry Version

0.16

What operating system are you using?

MacOS

What system architecture are you using?

x86

What happened

use starknet::ContractAddress;

#[starknet::interface]
trait IContractA<TContractState> {
    fn do_panic(self: @TContractState);
}

#[starknet::contract]
mod ContractA {
    #[storage]
    struct Storage {}

    #[abi(embed_v0)]
    impl Impl of super::IContractA<ContractState> {
        fn do_panic(self: @ContractState) {
            assert!(false, "foo");
        }
    }
}

#[starknet::interface]
trait IContractB<TContractState> {
    fn call_contractA(self: @TContractState, contract_address: ContractAddress);
}

#[starknet::contract]
mod ContractB {
    use starknet::ContractAddress;
    use super::{IContractADispatcherTrait, IContractADispatcher};

    #[storage]
    struct Storage {}

    #[abi(embed_v0)]
    impl Impl of super::IContractB<ContractState> {
        fn call_contractA(self: @ContractState, contract_address: ContractAddress) {
            IContractADispatcher { contract_address }.do_panic();
        }
    }
}

#[cfg(test)]
mod TestReverts {
    use snforge_std::{declare, ContractClassTrait};
    use super::{IContractADispatcherTrait, IContractADispatcher, IContractBDispatcherTrait, IContractBDispatcher};

    #[test]
    #[should_panic(expected: "foo")]
    fn test_should_panic_1() {
        let contractA_address = declare('ContractA').deploy(@array![]).unwrap();
        let contractA = IContractADispatcher { contract_address: contractA_address };
        contractA.do_panic();
    }

    #[test]
    #[should_panic(expected: "foo")]
    fn test_should_panic_2() {
        let contractA_address = declare('ContractA').deploy(@array![]).unwrap();
        let contractB_address = declare('ContractB').deploy(@array![]).unwrap();
        let contractB = IContractBDispatcher { contract_address: contractB_address };
        contractB.call_contractA(contractA_address);
    }
}

Trace

Is there an existing issue for this?

• I have searched the existing issues and verified no issue exits for this problem.

[drknzz]

Hey @delaaxe, snforge hasn't migrated to strings yet, so the example you provided should work if you change it to this:

#[starknet::contract]
mod ContractA {
    #[storage]
    struct Storage {}

    #[abi(embed_v0)]
    impl Impl of super::IContractA<ContractState> {
        fn do_panic(self: @ContractState) {
            assert(false, 'foo');
        }
    }
}

#[test]
#[should_panic(expected: ('foo',))]
fn test_should_panic_2() {
...

[drknzz]

Connected #1507

[delaaxe]

But the first test works though? El El mié, 31 ene 2024 a la(s) 9:22, Kamil Jankowski < ***@***.***> escribió:

…

Connected #1507 <#1507> — Reply to this email directly, view it on GitHub <#1627 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIKSPGJ2O4GCBGYOE3JNBLYRJHQNAVCNFSM6AAAAABCR44MG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGIYDENZYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[piotmag769]

This is a bug, related to #1344: we need to explore lower level methods to retrieve panic data from blockifier