Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ByteArray based errors handling #1679

Merged
merged 12 commits into from
Feb 12, 2024
Merged

ByteArray based errors handling #1679

merged 12 commits into from
Feb 12, 2024

Conversation

Arcticae
Copy link
Contributor

@Arcticae Arcticae commented Feb 7, 2024 •
edited
Loading

Closes #1627

Introduced changes

  • Adds a mechanism for parsing the errors from the trace and passing it on to test runner
  • Adds an extension for ease of further parsing the array

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@war-in war-in self-requested a review February 8, 2024 09:48
@Arcticae Arcticae marked this pull request as ready for review February 9, 2024 15:14
@Arcticae Arcticae requested review from a team as code owners February 9, 2024 15:14
@Arcticae Arcticae requested review from THenry14, DelevoXDG and drknzz and removed request for a team, THenry14 and DelevoXDG February 9, 2024 15:14
piotmag769
piotmag769 reviewed Feb 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
drknzz
drknzz approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

CHANGELOG.md Outdated Show resolved Hide resolved
docs/src/testing/contracts.md Outdated Show resolved Hide resolved
@Arcticae @piotmag769 @drknzz
Apply suggestions from code review
f6e0c7a 
Co-authored-by: Piotr Magiera <[email protected]>
Co-authored-by: Kamil Jankowski <[email protected]>
@Arcticae Arcticae added this pull request to the merge queue Feb 12, 2024
Merged via the queue into master with commit 7f2ff86 Feb 12, 2024
13 checks passed
@Arcticae Arcticae deleted the 1627-string-errors-not-caught branch February 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@war-in war-in war-in approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@drknzz drknzz drknzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panics not caught in a nested contracts
4 participants
@Arcticae @piotmag769 @war-in @drknzz