Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Cairo 2.5.3 and other refactors #271

Merged
merged 25 commits into from
Feb 8, 2024

Conversation

delaaxe
Copy link
Contributor

@delaaxe delaaxe commented Jan 31, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@delaaxe delaaxe requested a review from 0xLucqs as a code owner January 31, 2024 17:54
@0xLucqs
Copy link
Collaborator

0xLucqs commented Feb 1, 2024

put #272 and #270 in the same PR as this one

@delaaxe
Copy link
Contributor Author

delaaxe commented Feb 1, 2024 via email

@delaaxe delaaxe changed the title Cairo 2.5.0 basic upgrade Cairo 2.5.0 and other refactors Feb 1, 2024
@delaaxe
Copy link
Contributor Author

delaaxe commented Feb 1, 2024

@LucasLvy done

@delaaxe delaaxe changed the title Cairo 2.5.0 and other refactors Upgrade to Cairo 2.5.3 and other refactors Feb 2, 2024
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also change all the assert(x == y, 'xyz') into assert_eq!(x, y, "xyz"); you can use a regex for that

Scarb.toml Outdated Show resolved Hide resolved
src/ascii/src/integer.cairo Outdated Show resolved Hide resolved
src/bytes/src/bytes copy.cairo Outdated Show resolved Hide resolved
src/bytes/src/utils.cairo Outdated Show resolved Hide resolved
src/linalg/src/kron.cairo Outdated Show resolved Hide resolved
src/math/src/gcd_of_n_numbers.cairo Outdated Show resolved Hide resolved
src/math/src/lcm_of_n_numbers.cairo Outdated Show resolved Hide resolved
src/numeric/src/cumprod.cairo Outdated Show resolved Hide resolved
src/numeric/src/cumsum.cairo Outdated Show resolved Hide resolved
src/numeric/src/diff.cairo Outdated Show resolved Hide resolved
@delaaxe
Copy link
Contributor Author

delaaxe commented Feb 2, 2024

can you also change all the assert(x == y, 'xyz') into assert_eq!(x, y, "xyz"); you can use a regex for that

I would wait for snfoundry to be ready before doing it in library code because error message catching infra isn't fully implemented yet foundry-rs/starknet-foundry#1627

@delaaxe
Copy link
Contributor Author

delaaxe commented Feb 4, 2024

done as much as i could, it failed in many places (out of gas, formatter unimplemented, other weird errors)

@0xLucqs
Copy link
Collaborator

0xLucqs commented Feb 5, 2024

Let's not care about other tools, if someone wants to use it with foundry they'll use the old version

@delaaxe
Copy link
Contributor Author

delaaxe commented Feb 5, 2024

well we at argent would like to use the latest alexandria with foundry, but the assert! macros feel a bit too unstable to be shipped to mainnet

@0xLucqs 0xLucqs merged commit 800f5ad into keep-starknet-strange:main Feb 8, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants