Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRWEB-61 Lock enhanced-resolve to ~5.10.0 #81

Merged
merged 2 commits into from
Nov 23, 2022
Merged

STRWEB-61 Lock enhanced-resolve to ~5.10.0 #81

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e3ef5
Lock enhanced-resolve to ~5.10.0
mkuklis Nov 22, 2022
9cf41dc
Update webpack version
mkuklis Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"svgo": "^1.2.2",
"svgo-loader": "^2.2.1",
"tapable": "^1.0.0",
"ts-loader": "^8.2.0",
"ts-loader": "^9.4.1",
"typescript": "^4.2.4",
"util-ex": "^0.3.15",
"webpack-dev-middleware": "^5.2.1",
Expand All @@ -86,11 +86,14 @@
"mocha-junit-reporter": "^1.17.0",
"sinon": "^7.3.2",
"sinon-chai": "^3.3.0",
"webpack": "^5.58.1"
"webpack": "^5.75.0"
},
"peerDependencies": {
"react": "^17.0.2",
"react-dom": "^17.0.2",
"webpack": "^5.58.1"
"webpack": "^5.75.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkuklis, stripes-cli can't satisfy this because it's pinned to ~5.68.0 due to PR folio-org/stripes-cli#284. I know you said this build was successful locally. Did you try running karma/BTOG tests in any repo with this change in place?

How I would looooooove for this to be BTOG's death knell. If only it were so easy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zburke I haven't tried that. Let me just put it back to what it was and we can merge it.

},
"resolutions": {
"enhanced-resolve": "~5.10.0"
}
}