STRWEB-61 Lock enhanced-resolve to ~5.10.0 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncovercash, @JohnC-80: does anything spring to mind we should know about upgrading ts-loader from v8 to v9, e.g. do we need to sync this change with the @typescript-eslint libraries in eslint-config-stripes? |
|
@zburke I can't think of anything, the TS eslint can be maintained separately |
zburke
reviewed
Nov 22, 2022
package.json
Outdated
| "webpack": "^5.58.1" | ||
| "webpack": "^5.75.0" |
There was a problem hiding this comment.
@mkuklis, stripes-cli can't satisfy this because it's pinned to ~5.68.0 due to PR folio-org/stripes-cli#284. I know you said this build was successful locally. Did you try running karma/BTOG tests in any repo with this change in place?
How I would looooooove for this to be BTOG's death knell. If only it were so easy.
There was a problem hiding this comment.
@zburke I haven't tried that. Let me just put it back to what it was and we can merge it.
zburke
approved these changes
Nov 23, 2022
zburke
changed the title
zburke
added a commit
to folio-org/platform-complete
that referenced
this pull request
Nov 23, 2022
Avoid the buggy 5.11.0 release that appears to be incompatible with webpack-virtual-modules. Additional details at folio-org/stripes-webpack#81. Refs STRWEB-61
dcrossleyau
added a commit
to folio-org/platform-minimal
that referenced
this pull request
Nov 23, 2022
Avoid the buggy 5.11.0 release that appears to be incompatible with webpack-virtual-modules. Additional details at folio-org/stripes-webpack#81. Refs STRWEB-61
zburke
pushed a commit
that referenced
this pull request
Nov 23, 2022
Platform complete is currently failing due to an issue with enhanced-resolve v5.11.0 (thank you @zburke for pointing to it): webpack/enhanced-resolve#362 This PR locks `enhanced-resolve` to "~5.10.0" it also upgrades `ts-loader` to make sure a single version of enhanced-resolve is used in the dependency tree. Errors from https://jenkins-aws.indexdata.com/job/Automation/job/build-platform-complete-snapshot/13912/consoleText look like ``` "WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "29:14-33" ": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")" @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4 "WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "30:17-39" ": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")" @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4 "WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "31:19-43" ": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")" @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4 "WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "32:18-41" ": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")" @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4 "ERROR" in ": "./node_modules/@folio/stripes-core/src/App.js" "20:0-62" ": "Module "not found"": ": "Error"": ": Can't resolve 'stripes-config' in '/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/stripes-core/src'" @ ./node_modules/@folio/stripes-core/src/init.js 5:0-24 8:28-31 @ ./node_modules/@folio/stripes-core/index.js 35:0-45 35:0-45 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4 ... ``` Fixes STRWEB-61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform complete is currently failing with:
https://jenkins-aws.indexdata.com/job/Automation/job/build-platform-complete-snapshot/13912/consoleText
This is due to the issue with
enhanced-resolve v5.11.0(thank you @zburke for pointing to it):webpack/enhanced-resolve#362
This PR locks
enhanced-resolveto"~5.10.0"it also upgradests-loaderto make sure a single version ofenhanced-resolveis used in the dependency tree.Fixes STRWEB-61