Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCLI-195 pin webpack to ~5.68.0 #284

Merged
merged 1 commit into from
Apr 1, 2022
Merged

STCLI-195 pin webpack to ~5.68.0 #284

merged 1 commit into from
Apr 1, 2022

Conversation

zburke
Copy link
Member

@zburke zburke commented Apr 1, 2022

Oy, the hits just keep coming. It seems that 5.69.0 and 5.70.0 don't
play nice with moment and barf thousands of lines of warnings into the
log when running tests, but 5.69.1 isn't compatible with
karma-webpack which prevents tests from running at all. Yuck.

Sample build output:

$ stripes test karma --karma.singleRun --karma.browsers ChromeDocker --karma.reporters mocha junit --coverage
Starting Karma tests...
01 04 [20](https://github.com/folio-org/stripes-core/runs/5789164817?check_suite_focus=true#step:13:20)[22](https://github.com/folio-org/stripes-core/runs/5789164817?check_suite_focus=true#step:13:22) 14:07:[29](https://github.com/folio-org/stripes-core/runs/5789164817?check_suite_focus=true#step:13:29).960:ERROR [plugin]: Cannot find plugin "karma-webpack".
  Did you forget to install it?
  npm install karma-webpack --save-dev
01 04 2022 14:07:30.187:ERROR [plugin]: Cannot load "webpack", it is not registered!
  Perhaps you are missing some plugin?
01 04 2022 14:07:30.188:ERROR [karma-server]: Server start failed on port 9876: Error: No provider for "framework:webpack"! (Resolving: framework:webpack)
Karma exited with 1
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Refs STCLI-195

Oy, the hits just keep coming. It seems that `5.69.0` and `5.70.0` don't
play nice with `moment` and barf thousands of lines of warnings into the
log when running tests, but `5.69.1` isn't compatible with
`karma-webpack` which prevents tests from running _at all_. Yuck.

Refs STCLI-195
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Jest Unit Test Statistics

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f163733. ± Comparison against base commit ad6089a.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

BigTest Unit Test Statistics

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f163733. ± Comparison against base commit ad6089a.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke zburke merged commit 1195042 into master Apr 1, 2022
@zburke zburke deleted the STCLI-195-again branch April 1, 2022 17:18
zburke added a commit that referenced this pull request Apr 5, 2022
Oy, the hits just keep coming. It seems that `5.69.0` and `5.70.0` don't
play nice with `moment` and barf thousands of lines of warnings into the
log when running tests, but `5.69.1` isn't compatible with
`karma-webpack` which prevents tests from running _at all_. Yuck.

Refs STCLI-195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants