Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local cache ignore portion #1914

Closed
wants to merge 9 commits into from

Conversation

troychiu
Copy link
Member

TL;DR

Users can specify input vars that will not be included when calculating cache

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  1. Add "cache_ignore_input_vars" to task's metadata
  2. Check if an input var is in the cache_ignore_input_vars while calculating the hash for cache, skip the input var if yes.

Tracking Issue

flyteorg/flyte#3058

Follow-up issue

Have to implement the same thing for remote cache

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e41ec1e) 94.95% compared to head (fd86070) 39.92%.

❗ Current head fd86070 differs from pull request most recent head 2b73159. Consider uploading reports for the commit 2b73159 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1914       +/-   ##
===========================================
- Coverage   94.95%   39.92%   -55.03%     
===========================================
  Files         136      171       +35     
  Lines        6165    16828    +10663     
  Branches        0     3493     +3493     
===========================================
+ Hits         5854     6719      +865     
- Misses        311     9936     +9625     
- Partials        0      173      +173     
Files Coverage Δ
flytekit/core/task.py 66.66% <100.00%> (ø)
flytekit/models/task.py 58.77% <50.00%> (ø)
flytekit/core/local_cache.py 39.58% <50.00%> (ø)
flytekit/core/base_task.py 44.77% <11.11%> (ø)

... and 303 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
@troychiu
Copy link
Member Author

Closing as satisfied by flyteorg/flyte#2275

@troychiu troychiu closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant