Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local cache ignore portion #1914

Closed
wants to merge 9 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
Signed-off-by: troychiu <y.troychiu@gmail.com>
troychiu committed Nov 3, 2023
commit 73cccb358d41effe0f8ea8e7b173638dcf171002
4 changes: 3 additions & 1 deletion tests/flytekit/common/parameterizers.py
Original file line number Diff line number Diff line change
@@ -125,8 +125,9 @@
deprecated,
cache_serializable,
pod_template_name,
cache_ignore_input_vars,
)
for discoverable, runtime_metadata, timeout, retry_strategy, interruptible, discovery_version, deprecated, cache_serializable, pod_template_name in product(
for discoverable, runtime_metadata, timeout, retry_strategy, interruptible, discovery_version, deprecated, cache_serializable, pod_template_name, cache_ignore_input_vars in product(
[True, False],
LIST_OF_RUNTIME_METADATA,
[timedelta(days=i) for i in range(3)],
@@ -136,6 +137,7 @@
["deprecated"],
[True, False],
["A", "B"],
[(), ("a", "b")],
)
]

1 change: 1 addition & 0 deletions tests/flytekit/unit/extend/test_agent.py
Original file line number Diff line number Diff line change
@@ -100,6 +100,7 @@ def get_task_template(task_type: str) -> TaskTemplate:
"This is deprecated!",
True,
"A",
(),
)

interfaces = interface_models.TypedInterface(
3 changes: 3 additions & 0 deletions tests/flytekit/unit/models/test_tasks.py
Original file line number Diff line number Diff line change
@@ -73,6 +73,7 @@ def test_task_metadata():
"This is deprecated!",
True,
"A",
(),
)

assert obj.discoverable is True
@@ -142,6 +143,7 @@ def test_task_spec():
"This is deprecated!",
True,
"A",
(),
)

int_type = types.LiteralType(types.SimpleType.INTEGER)
@@ -202,6 +204,7 @@ def test_task_template_k8s_pod_target():
"deprecated",
False,
"A",
(),
),
interface_models.TypedInterface(
# inputs
1 change: 1 addition & 0 deletions tests/flytekit/unit/models/test_workflow_closure.py
Original file line number Diff line number Diff line change
@@ -42,6 +42,7 @@ def test_workflow_closure():
"This is deprecated!",
True,
"A",
(),
)

cpu_resource = _task.Resources.ResourceEntry(_task.Resources.ResourceName.CPU, "1")