Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] flytepropeller gracefully cleanup CRDs missing execution #2275

Closed
2 tasks done
ckiosidis opened this issue Mar 17, 2022 · 0 comments · Fixed by flyteorg/flytepropeller#439
Closed
2 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ckiosidis
Copy link
Contributor

ckiosidis commented Mar 17, 2022

Describe the bug

When an execution does not exist in flyteadmin but the CRD has been created, Flytepropeller continuously tries to reconcile the flyteworkflow CRD but fails.

example of resource status


  failedAttempts: 15086
  message: 'Workflow[] failed. ErrorRecordingError: failed to publish event, caused
    by: ExecutionNotFound: The execution that the event belongs to does not exist,
    caused by [rpc error: code = NotFound desc = missing entity of type execution
    with identifier project:"flyte-canary" domain:"production" name:"tvy2szcxi7bcnzg36oef"
    ]'
  phase: 0

https://flyte-org.slack.com/archives/C01P3B761A6/p1647350804430329

Expected behavior

Flytepropeller should gracefully fail and clean up the crd of the non-existent execution (at least after exhausting the retries)

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ckiosidis ckiosidis added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Mar 17, 2022
@hamersaw hamersaw self-assigned this Mar 17, 2022
@hamersaw hamersaw removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 17, 2022
@hamersaw hamersaw added this to the 1.0.1 milestone Mar 17, 2022
@EngHabu EngHabu modified the milestones: 1.0.1, 1.0.2 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants