Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Added pflag support in cli #11

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Added pflag support in cli #11

merged 4 commits into from
Jul 26, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Jul 17, 2021

TL;DR

Added pflag support for a dependent pr https://github.com/flyteorg/flyteplugins/pull/191/files

  • bump new version of flytestdlib for flag support

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes flyteorg/flyte#1253

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@yindia yindia requested review from EngHabu and kumare3 as code owners July 17, 2021 18:28
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #11 (d8ba933) into master (da8ebe1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   17.79%   17.79%           
=======================================
  Files           3        3           
  Lines         399      399           
=======================================
  Hits           71       71           
  Misses        315      315           
  Partials       13       13           
Flag Coverage Δ
unittests 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8ebe1...d8ba933. Read the comment docs.

go.sum Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia requested a review from pmahindrakar-oss July 26, 2021 12:57
@wild-endeavor wild-endeavor merged commit 478f363 into flyteorg:master Jul 26, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Flyte copilot should not need explicit configuration - flyte-data-config
3 participants