Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Flyte copilot should not need explicit configuration - flyte-data-config #1253

Closed
kumare3 opened this issue Jul 16, 2021 · 1 comment · Fixed by flyteorg/flytecopilot#11
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free plugins Plugins related labels (backend or frontend)
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jul 16, 2021

Describe the Issue
Related to #1251.
Flyte co-pilot currently needs an explicit configmap to control the storage configuration. this is only required, because till recently flytestdlib did not support commandline updates to config vars. This has now been fixed.

This issue proposes that we upgrade copilot to new config and then update flyteplugins to pass the default flytepropeller storage configuration, with few modifications as command line parameters.

Controlled from here https://github.com/flyteorg/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/copilot.go. Delete this https://github.com/flyteorg/flyte/blob/master/helm/templates/_helpers.tpl#L207-L216

Modifications:
enable-multicontainer: True
default download limit.

We should also adjust the StorageSize based on user provided information.
https://github.com/flyteorg/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/copilot.go#L214 and default to a reasonable value

What if we do not do this?
CoPilot cannot download a lot of data.

Related component
FlytePlugins. Flyte-copilot

@kumare3 kumare3 added plugins Plugins related labels (backend or frontend) housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jul 16, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Jul 16, 2021

cc @evalsocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free plugins Plugins related labels (backend or frontend)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants