[Housekeeping] Flyte copilot should not need explicit configuration - flyte-data-config #1253
Labels
housekeeping
Issues that help maintain flyte and keep it tech-debt free
plugins
Plugins related labels (backend or frontend)
Milestone
Describe the Issue
Related to #1251.
Flyte co-pilot currently needs an explicit configmap to control the storage configuration. this is only required, because till recently flytestdlib did not support commandline updates to config vars. This has now been fixed.
This issue proposes that we upgrade copilot to new config and then update flyteplugins to pass the default flytepropeller storage configuration, with few modifications as command line parameters.
Controlled from here https://github.com/flyteorg/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/copilot.go. Delete this https://github.com/flyteorg/flyte/blob/master/helm/templates/_helpers.tpl#L207-L216
Modifications:
enable-multicontainer: True
default download limit.
We should also adjust the StorageSize based on user provided information.
https://github.com/flyteorg/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/copilot.go#L214 and default to a reasonable value
What if we do not do this?
CoPilot cannot download a lot of data.
Related component
FlytePlugins. Flyte-copilot
The text was updated successfully, but these errors were encountered: