Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Copilot should be allowed to download unlimited data - if needed #1251

Closed
yindia opened this issue Jul 16, 2021 · 1 comment · Fixed by flyteorg/flytestdlib#93 or flyteorg/flyteplugins#191
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Milestone

Comments

@yindia
Copy link
Contributor

yindia commented Jul 16, 2021

Describe the Issue
The issue is reported in the slack channel by Bernhard Stadlbauer.

Hi!
We're using a ContainerTask to run some of our native things. Some of the inputs that the container receives are ~500mb. When running the Task, the flyte-copilot-downloader container in the pod fails with:
{"json":{},"level":"error","msg":"Failed to persist [<INPUT_NAME>], err failed to read Blob from storage: [LIMIT_EXCEEDED] limit exceeded. 479mb \u003e 2mb.","ts":"2021-07-16T09:06:19Z"}
When this happens, the Task does not fail directly (which would be nice), but only when we try to open the input file in the actual container on the pod.
Is there a way to increase this limit?

Fix: Copilot should be allowed to download as much as needed. We don't need any limit.

What if we do not do this?
Short description of potential consequences

Related component
Either Specific / all

@yindia yindia added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Jul 16, 2021
@yindia yindia added this to the 0.16.0 milestone Jul 16, 2021
@yindia yindia self-assigned this Jul 16, 2021
@kumare3 kumare3 changed the title [Housekeeping] Copilot should be allowed to download as much as needed [Housekeeping] Copilot should be allowed to download unlimited data - if needed Jul 16, 2021
@kumare3
Copy link
Contributor

kumare3 commented Jul 16, 2021

This will need changes in flytestdlib to support default limits of 0 which would mean unlimited.
https://github.com/flyteorg/flytestdlib/blob/master/storage/config.go#L103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants