Added pflag support in cli (#11)

Signed-off-by: Yuvraj <[email protected]>
flyteorg · Jul 26, 2021 · 0fb6560 · 0fb6560
1 parent 2c8378c
commit 0fb6560
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 97 deletions.
diff --git a/flytecopilot/cmd/root.go b/flytecopilot/cmd/root.go
@@ -162,17 +162,19 @@ func NewDataCommand() *cobra.Command {
 	return command
 }
 
-func (r *RootOptions) initConfig(_ *cobra.Command, _ []string) error {
+func (r *RootOptions) initConfig(cmd *cobra.Command, _ []string) error {
 	r.configAccessor = viper.NewAccessor(config.Options{
 		StrictMode:  true,
 		SearchPaths: []string{r.cfgFile},
 	})
 
+	// persistent flags were initially bound to the root command so we must bind to the same command to avoid
+	r.configAccessor.InitializePflags(cmd.PersistentFlags())
+
 	err := r.configAccessor.UpdateConfig(context.TODO())
 	if err != nil {
 		return err
 	}
-
 	return nil
 }
 

diff --git a/flytecopilot/go.mod b/flytecopilot/go.mod
@@ -5,7 +5,7 @@ go 1.13
 require (
 	github.com/aws/aws-sdk-go v1.37.1
 	github.com/flyteorg/flyteidl v0.18.15
-	github.com/flyteorg/flytestdlib v0.3.20
+	github.com/flyteorg/flytestdlib v0.3.30
 	github.com/fsnotify/fsnotify v1.4.9
 	github.com/ghodss/yaml v1.0.0
 	github.com/golang/protobuf v1.4.3