Fixed undefined task input types access in NodeExecutionActions

[MorpheusXAUT]

TL;DR

Ensured task input types are retrieved properly before trying to prepare initial parameters for NodeExecutionActions relaunch form.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Similar as with ExecutionDetailsActions, a race condition exists when expanding NodeExecutionActions - the task and its input types are sometimes not loaded properly, resulting in an (unchecked) access to retrieve an input's type.
#506 already fixed this race condition for the ExecutionDetailsActions, this PR applies the identical change to the NodeExecutionActions.

I've based this PR against devmain instead of master as the other fix has been applied there as well - can rebase if needed. Tests seem to be failing locally/in our CI, but that was the case without my changes as well as it seems...
I didn't explicitly add any additional unit tests since the original PR didn't have any either, but can do so if you let me know what you'd like to have verified.

That said: is there any chance to get both of these fixes merged into master as we're currently experiencing both in the latest published version (and are thus running our own fork so developers can work)? 🙂

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/535

Follow-up issue

NA

[anrusina]

Looks good.
@MorpheusXAUT Could you please base it on top of master.
I believe it also will solve test issue.
After that I will approve, merge and generate release :)
We retired devmain branch some time ago (But I forgot to delete it in timed manner). It was used while we changed repository structure to simplify merge to master.

[MorpheusXAUT]

@MorpheusXAUT Could you please base it on top of master.

Sure thing, will do tomorrow morning 🙂
@anrusina Would you also like me to cherry-pick d38b98b from the other PR as well so it gets merged into master at the same time?

[anrusina]

Would you also like me to cherry-pick [d38b98b] from the other PR as well so it gets merged into master at the same time?

@MorpheusXAUT Yes, please.
I was pretty sure it was already merged. Makes one wonder if all commits from devmain end up in master... 😳 Will run some checks later this week :)

[MorpheusXAUT]

@anrusina Alright, after a slight confusion during rebasing (keeping 3 repos in sync turns out to be quite a handful 😅 sorry about the mess), I've rebased this onto master and cherry-picked d38b98b on top.
Should be good to take another look.

EDIT: I'll look into the failing test shortly.
EDIT2: Tests seem to be passing locally, not sure what's wrong here 🤔

[codecov]

Codecov Report

Merging #538 (4044d24) into master (59d5d2a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   69.42%   69.43%   +0.01%     
==========================================
  Files         439      439              
  Lines       10282    10286       +4     
  Branches     1753     1753              
==========================================
+ Hits         7138     7142       +4     
  Misses       3144     3144              

Impacted Files	Coverage Δ
...tions/ExecutionDetails/ExecutionDetailsActions.tsx	88.63% <100.00%> (+0.54%)	⬆️
...ponents/Executions/Tables/NodeExecutionActions.tsx	90.47% <100.00%> (+0.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d5d2a...4044d24. Read the comment docs.

[anrusina]

Lgtm!
@MorpheusXAUT thank for fixing it :)
Not sure what was wrong with test as I also wasn't able to repro it locally. Restarted tests and they now succeed.

Will merge in a minute and create new release in a bit. Do you usually pickup releases from :

• Flyteconsole
  OR
• FlyteConsole-Release - FlyteConsole-Release

I would prefer to push it only to flyteconsole, if it is enough.

[MorpheusXAUT]

Will merge in a minute and create new release in a bit. Do you usually pickup releases from :

• Flyteconsole
  OR
• FlyteConsole-Release - FlyteConsole-Release

I would prefer to push it only to flyteconsole, if it is enough.

Thanks, appreciated :)
We pick up our releases from Flyteconsole, so that's fine by me.