Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node executions stale context for relaunched executions #625

Merged
merged 100 commits into from
Oct 26, 2022

Conversation

olga-union
Copy link
Contributor

TL;DR

Cached React Query response was feeding stale data to context for relaunched executions, hence all data was showing progress, and then reverting to previous run data.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Demo

Screen.Recording.2022-10-25.at.6.24.06.PM.mov

Tracking Issue

NA

Follow-up issue

NA

anrusina and others added 30 commits May 17, 2022 18:05
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
* ci: move storybook related packages to top level
* ci: ensure that lint can be run in PR checks
* ci: allow to run tests linux setup

Signed-off-by: Nastya Rusina <[email protected]>
#436)

* ci: ensure unified tsconfig and remove mocks,test,stories from build
* ci: move certificates into certificate folder inside script

Signed-off-by: Nastya Rusina <[email protected]>
* fix: issue 398
* fix: prevent parent onclick event trigger

Signed-off-by: eugenejahn <[email protected]>
* fix: unable to view all the workflow versions

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
* chore(tsc): exclude test/stories/mock files only from build

Signed-off-by: Nastya Rusina <[email protected]>
* chore: support for StructuredDataSet Input/Output type

Signed-off-by: Carina Ursu <[email protected]>

* chore: add tests

Signed-off-by: Carina Ursu <[email protected]>

* chore: add package

Signed-off-by: Carina Ursu <[email protected]>

* chore: resolving local package issue

Signed-off-by: Carina Ursu <[email protected]>

* chore: yarn lock

Signed-off-by: Carina Ursu <[email protected]>

* chore: stories

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix associative arrays in copy functionality

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix scalar stories

Signed-off-by: Carina Ursu <[email protected]>

* chore: oops

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: revert old viewer to original

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix

Signed-off-by: Carina Ursu <[email protected]>

* chore: remove non-null assertion

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix types

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix tests

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix test types

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
…scode setup properly (#458)

* chore: separate AppInfo
* chore: vscode properly understands @flyteconsole
* chore: add basics/locale entry
* test: add storybooks and tests
* test: fix istanbul test-coverage issue by binding babel versions

Signed-off-by: Nastya Rusina <[email protected]>
* ci: minimize babel presence

Signed-off-by: Nastya Rusina <[email protected]>
* fix: update node executions to display map tasks
* fix: update map task logs styles
* test: add/update unit tests
* fix: fix flickering and unnecessary re-renders

Signed-off-by: Olga Nad <[email protected]>
* ci: resolve docker build issues
* chore: remove unneeded changes

Signed-off-by: Nastya Rusina <[email protected]>
* chore: fix

Signed-off-by: Carina Ursu <[email protected]>

* chore: remove console

Signed-off-by: Carina Ursu <[email protected]>

* chore: add cherio o=to package

Signed-off-by: Carina Ursu <[email protected]>

* chore: add cherio o=to package

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix start prod

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix start prod

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
made the entities component become more generic that can support Workflow, Task, and others
added the inputs and outputs to task details page
added the versions table in task details page
added the version details page
added task details link in node side panel

Signed-off-by: eugenejahn <[email protected]>

Co-authored-by: Eugene Jahn <[email protected]>
* hotfix ci pipeline

Signed-off-by: Yuvraj <[email protected]>

* more changes

Signed-off-by: Yuvraj <[email protected]>

Co-authored-by: Yuvraj <[email protected]>
ursucarina and others added 19 commits September 7, 2022 08:53
fix: inputHelpers InputProps

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>
* fix: fix test of launchform

Signed-off-by: James <[email protected]>

* fix: inputHelpers tests regression

Signed-off-by: Olga Nad <[email protected]>

* fix: update tests description

Signed-off-by: Olga Nad <[email protected]>

* fix: spelling typo

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: James <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
Co-authored-by: Olga Nad <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>
Minor change

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>
* fix: add BASE_URL to dev startup, open deeply nested urls

Signed-off-by: Carina Ursu <[email protected]>

* fix: remove debug code

Signed-off-by: Carina Ursu <[email protected]>

* chore: empty BASE_URL handling

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>
* fix: add default disabled state for only mine filter

Signed-off-by: Olga Nad <[email protected]>

* fix: tests

Signed-off-by: Olga Nad <[email protected]>

* fix: use api context to default filter state

Signed-off-by: Olga Nad <[email protected]>

* fix: revert test updates

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>
* progress

* Fixed

* Removed debug code

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>
chore: enable deeplinks in development

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>
@olga-union olga-union requested review from a team, ursucarina, eugenejahn and jsonporter and removed request for a team October 25, 2022 23:27
Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #625 (ecc044a) into devmain (be9f643) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           devmain     #625      +/-   ##
===========================================
+ Coverage    67.46%   67.50%   +0.03%     
===========================================
  Files          447      447              
  Lines        10648    10659      +11     
  Branches      1831     1834       +3     
===========================================
+ Hits          7184     7195      +11     
  Misses        3464     3464              
Impacted Files Coverage Δ
...Executions/ExecutionDetails/ExecutionNodeViews.tsx 98.82% <ø> (ø)
...nents/Executions/ExecutionDetails/ExecutionTab.tsx 100.00% <ø> (ø)
...xecutions/ExecutionDetails/ExecutionTabContent.tsx 74.38% <ø> (ø)
...mponents/Executions/Tables/NodeExecutionsTable.tsx 75.40% <ø> (ø)
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 81.20% <100.00%> (ø)
...components/Executions/NodeExecutionCacheStatus.tsx 92.00% <100.00%> (ø)
...ponents/Executions/Tables/NodeExecutionActions.tsx 93.65% <100.00%> (+0.43%) ⬆️
.../src/components/Executions/nodeExecutionQueries.ts 58.78% <100.00%> (+2.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jsonporter jsonporter merged commit 32d48c9 into devmain Oct 26, 2022
@jsonporter jsonporter deleted the olga-union/fix-cached-renders branch October 26, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants