Skip to content

Commit

Permalink
fix: node executions stale context for relaunched executions (#625)
Browse files Browse the repository at this point in the history
* chore: move src to a new location

Signed-off-by: Nastya Rusina <[email protected]>

* ci: allow branch to be built again

Signed-off-by: Nastya Rusina <[email protected]>

* chore: replace link to github repository to a proper one

Signed-off-by: Nastya Rusina <[email protected]>

* ci: basic test and test-coverage setup

Signed-off-by: Nastya Rusina <[email protected]>

* chore: add first plugin package

Signed-off-by: Nastya Rusina <[email protected]>

* chore: allow to start test from main directory

Signed-off-by: Nastya Rusina <[email protected]>

* ci: update lowest mkdirp version (#423)

Signed-off-by: Nastya Rusina <[email protected]>

* chore: add build scripts for console app (#429)

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>

* fix: hide the legend (#435)

Signed-off-by: eugenejahn <[email protected]>

* ci: move storybook related packages to top level (#434)

* ci: move storybook related packages to top level
* ci: ensure that lint can be run in PR checks
* ci: allow to run tests linux setup

Signed-off-by: Nastya Rusina <[email protected]>

* fix: fix issue 386 (#437)

Signed-off-by: eugenejahn <[email protected]>

* ci: ensure unified tsconfig and remove mocks, test, stories from build (#436)

* ci: ensure unified tsconfig and remove mocks,test,stories from build
* ci: move certificates into certificate folder inside script

Signed-off-by: Nastya Rusina <[email protected]>

* Make whole row clickable to open TaskExecutionDetails panel (#444)

* fix: issue 398
* fix: prevent parent onclick event trigger

Signed-off-by: eugenejahn <[email protected]>

* ci: allow to start jest config for all project at once (#447)

* minor: unable to view all the workflow versions (#446)

* fix: unable to view all the workflow versions

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>

* chore(tsc): exclude test/stories/mock files only from build (#451)

* chore(tsc): exclude test/stories/mock files only from build

Signed-off-by: Nastya Rusina <[email protected]>

* ci: ensure that webpack too doesn't include test/mock/specs files (#452)

Signed-off-by: Nastya Rusina <[email protected]>

* minor: add support for StructuredDataSet Input/Output type (#445)

* chore: support for StructuredDataSet Input/Output type

Signed-off-by: Carina Ursu <[email protected]>

* chore: add tests

Signed-off-by: Carina Ursu <[email protected]>

* chore: add package

Signed-off-by: Carina Ursu <[email protected]>

* chore: resolving local package issue

Signed-off-by: Carina Ursu <[email protected]>

* chore: yarn lock

Signed-off-by: Carina Ursu <[email protected]>

* chore: stories

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix associative arrays in copy functionality

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix scalar stories

Signed-off-by: Carina Ursu <[email protected]>

* chore: oops

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: revert old viewer to original

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix

Signed-off-by: Carina Ursu <[email protected]>

* chore: remove non-null assertion

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix types

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix tests

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix test types

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>

* chore: Provide basic repo structure and ensure that stories, tests, vscode setup properly (#458)

* chore: separate AppInfo
* chore: vscode properly understands @flyteconsole
* chore: add basics/locale entry
* test: add storybooks and tests
* test: fix istanbul test-coverage issue by binding babel versions

Signed-off-by: Nastya Rusina <[email protected]>

* ci: minimize babel presence (#457)

* ci: minimize babel presence

Signed-off-by: Nastya Rusina <[email protected]>

* fix: update node executions to display map tasks (#455)

* fix: update node executions to display map tasks
* fix: update map task logs styles
* test: add/update unit tests
* fix: fix flickering and unnecessary re-renders

Signed-off-by: Olga Nad <[email protected]>

* ci: resolve docker build issues (#462)

* ci: resolve docker build issues
* chore: remove unneeded changes

Signed-off-by: Nastya Rusina <[email protected]>

* Chore: Rebase devmain on top of master (#464)

* fix: ensure that admin version is fully shown (#465)

* chore: fix for console not respecting admin url (#468)

* chore: fix

Signed-off-by: Carina Ursu <[email protected]>

* chore: remove console

Signed-off-by: Carina Ursu <[email protected]>

* chore: add cherio o=to package

Signed-off-by: Carina Ursu <[email protected]>

* chore: add cherio o=to package

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix start prod

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix start prod

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>

* chore: rebase on top of master

Signed-off-by: Nastya <[email protected]>

* fix: trigger release #patch (#477)

Signed-off-by: Nastya <[email protected]>

* feat: add task version info (#485)

made the entities component become more generic that can support Workflow, Task, and others
added the inputs and outputs to task details page
added the versions table in task details page
added the version details page
added task details link in node side panel

Signed-off-by: eugenejahn <[email protected]>

Co-authored-by: Eugene Jahn <[email protected]>

* chore: update Readme with python note + package version update (#486)

Signed-off-by: Nastya Rusina <[email protected]>

Co-authored-by: Nastya Rusina <[email protected]>

* hotfix ci pipeline (#487)

* hotfix ci pipeline

Signed-off-by: Yuvraj <[email protected]>

* more changes

Signed-off-by: Yuvraj <[email protected]>

Co-authored-by: Yuvraj <[email protected]>

* [Mapping][TaskInfo] V.2 - Update Task details to allow check information for child task execution (#467)

* fix: add eventVersion check for map tasks (#484)

* fix: resolve minimist package to v1.2.6 (#492)

Signed-off-by: Nastya <[email protected]>

* ci: add flyte-api plugin package (#490)

Signed-off-by: Nastya <[email protected]>

* fix: update/add graph related stories (#493)

* fix: separate api auth to plugin folder (#495)

* fix: separate api auth to plugin folder
* chore: for local admin URL is undefined
* chore: update README.md
* test: fix tests + add new ones
* v0.0.2 - release for flyte-api plugin

Signed-off-by: Nastya <[email protected]>

* feat: rerun task action in execution page  (#488)

* feat: task rerun done

Signed-off-by: Eugene Jahn <[email protected]>

* feat: fix initialParameters

Signed-off-by: Eugene Jahn <[email protected]>

* fix: remove a file

Signed-off-by: Eugene Jahn <[email protected]>

* feat: rerun task done

Signed-off-by: Eugene Jahn <[email protected]>

* feat: rerun fix literal type

Signed-off-by: Eugene Jahn <[email protected]>

* feat: small typo fixed

Signed-off-by: Eugene Jahn <[email protected]>

* feat: small typo fixed

Signed-off-by: Eugene Jahn <[email protected]>

* feat: fix test coverage

Signed-off-by: Eugene Jahn <[email protected]>

* chore: update release version (#501)

Signed-off-by: Nastya <[email protected]>

* chore(deps-dev): bump protobufjs from 6.8.9 to 6.11.3 (#502)

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.8.9 to 6.11.3.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md)
- [Commits](https://github.com/protobufjs/protobuf.js/commits/v6.11.3)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: add package generator for basics/composites/plugins (#503)

* chore: add package generator for basics/composites/plugins

Signed-off-by: Nastya <[email protected]>

* Update CONTRIBUTING.md  with package generate info

* fix(bug-508): executions can not be filtered by start time (#509)

Signed-off-by: Nastya <[email protected]>

* chore(deps-dev): bump semantic-release from 17.2.3 to 19.0.3 (#510)

Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 17.2.3 to 19.0.3.
- [Release notes](https://github.com/semantic-release/semantic-release/releases)
- [Commits](semantic-release/semantic-release@v17.2.3...v19.0.3)

---
updated-dependencies:
- dependency-name: semantic-release
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: support flyte decks (#504)

* feat: support flyte deck #none

Signed-off-by: James <[email protected]>

* fix: rebase with master #none

Signed-off-by: James <[email protected]>

* fix: fix iframe height and api response type; #none

Signed-off-by: James <[email protected]>

* fix: modal style; #none;

Signed-off-by: James <[email protected]>

* fix: use env variable for server ssl config #none;

Signed-off-by: James <[email protected]>

* fix: use h2 instead of h3 for future migration #none

Signed-off-by: James <[email protected]>

* feat: navbar navigation dropdown (#511)

* feat: navbar navigstion dropdown
* chore: storybook update
* chore: fix test + add base readme

Signed-off-by: Nastya <[email protected]>

* chore: support internal/external navigsation better (#513)

Signed-off-by: Nastya <[email protected]>

* Update Contributing.md (#515)

Add line how to add nodejs plugin to asdf, to simplify setup

* chore: update navigationDropdown usage (#517)

Signed-off-by: Work <[email protected]>

Co-authored-by: Work <[email protected]>

* chore(deps): bump jsdom from 16.4.0 to 16.7.0 (#516)

Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.7.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](jsdom/jsdom@16.4.0...16.7.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: launch plans list & detail page #none; (#507)

* feat: launch plans list #none;
* fix: launch plan detail page the top navigation header
* fix: added expected inputs and fixed inputs; #none
* fix: remove radio buttons for view all launch plan versions; #none

Signed-off-by: James <[email protected]>

* chore: release 1.1.3 (#520)

Signed-off-by: Nastya Rusina <[email protected]>

* fix: cache icon fro map task (#519)

* fix: cache icon fro map task
* fix: icon and text center

Signed-off-by: eugenejahn <[email protected]>

* fix: Relaunch form does not persist security context values when changed (#527)

fix: use execution security context in relaunch; #none

Signed-off-by: James <[email protected]>

* fix: release process (#529)

* fix release process

Signed-off-by: Yuvraj <[email protected]>

* more changes

Signed-off-by: Yuvraj <[email protected]>

* more changes

Signed-off-by: Yuvraj <[email protected]>

* fix workflow

Signed-off-by: Yuvraj <[email protected]>

Co-authored-by: Yuvraj <[email protected]>

* fix: fix semantic-release config (#532)

Signed-off-by: Yuvraj <[email protected]>

* test: fix time sensitive test (#533)

chore: fix test

Signed-off-by: Nastya Rusina <[email protected]>

* Rename upgrade idl workflow (#534)

Signed-off-by: Yuvraj <[email protected]>

Co-authored-by: Yuvraj <[email protected]>

* fix: support mapped tasks (#494)

* fix: support mapped tasks #none

Signed-off-by: James <[email protected]>

* fix: fix comments #none

Signed-off-by: James <[email protected]>

* fix: fix unit test #none

Signed-off-by: James <[email protected]>

* fix: add string constants #none

Signed-off-by: James <[email protected]>

* fix: added test for mapInputHelper #none

Signed-off-by: James <[email protected]>

* fix: fix test for utils.test.ts #none

Signed-off-by: James <[email protected]>

* chore: trigger snyk re-run

* fix: multiple keys for mapped types; #none

Signed-off-by: James <[email protected]>

* chore: storybook item (#530)

Signed-off-by: Nastya Rusina <[email protected]>

* fix: fix validation for duplicate and fix focus issue

Signed-off-by: James <[email protected]>

* chore: provide previous run values on relaunch

Signed-off-by: Nastya Rusina <[email protected]>

Co-authored-by: Nastya <[email protected]>
Co-authored-by: Nastya Rusina <[email protected]>

* fix(491): remove favicon package + use favicon.svg by default (#537)

* fix(491): remove favicon package + use favicon.svg by default

Signed-off-by: Nastya Rusina <[email protected]>

* chore: resolve yarn.lock merge conflict

Signed-off-by: Nastya Rusina <[email protected]>

* Fixed undefined task input types access in NodeExecutionActions (#538)

* Fixed undefined task input types access in NodeExecutionActions
Issue occurred due to race condition while loading data, indentical fix applies as for #506

Signed-off-by: Nick Müller <[email protected]>

* fix: cannot read properties of undefined (#506)

fix: nullref

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
(cherry picked from commit d38b98b)

Signed-off-by: Nick Müller <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>

* feat: support union type for launch plan (#540)

* feat: support union type for launch plan

Signed-off-by: eugenejahn <[email protected]>

* fix: format

Signed-off-by: eugenejahn <[email protected]>

* fix: update type label

Signed-off-by: eugenejahn <[email protected]>

* fix: update the format

Signed-off-by: eugenejahn <[email protected]>

* fix: graph has realtime updates as execution progresses (#543)

Signed-off-by: Olga Nad <[email protected]>

* fix: make sure groups used in graph aren't undefined (#545)

Signed-off-by: Olga Nad <[email protected]>

* Hotfix docker push GHWF (#547)

* Rename upgrade idl workflow

Signed-off-by: Yuvraj <[email protected]>

* fix docker push wf

Signed-off-by: Yuvraj <[email protected]>

Co-authored-by: Yuvraj <[email protected]>

* fix: Graph Center on initial render (#541)

* fix: upgrade react-flow-renderer version

Signed-off-by: James <[email protected]>

* fix: use setTimeout for queue on the next render

Signed-off-by: James <[email protected]>

* fix: use one state variable and fitView after nodesChange

Signed-off-by: James <[email protected]>

* introduce needFitView

* fix: graph edge overlaps nodes (#542)

* fix: upgrade react-flow-renderer version

Signed-off-by: James <[email protected]>

* fix: use setTimeout for queue on the next render

Signed-off-by: James <[email protected]>

* fix: use one state variable and fitView after nodesChange

Signed-off-by: James <[email protected]>

* fix: graph edge overlaps nodes issue

Signed-off-by: James <[email protected]>

* introduce needFitView

* edge overlap

* fix: flyteconsole tag in ci pipeline  (#550)

* fix tag issue in ci

Signed-off-by: Yuvraj <[email protected]>

* remove welcome bot from boilerplate config

Signed-off-by: Yuvraj <[email protected]>

Co-authored-by: Yuvraj <[email protected]>

* enable docker push for console (#552)

* chore(deps): bump terser from 4.8.0 to 4.8.1 (#548)

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Flyteidl version (#558)

Signed-off-by: Flyte-Bot <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>

* fix: fix searchbar X button (#564)

chore: fix searchbar X button

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>

* fix: update timeline view to show dynamic wf internals on first render (#562)

* fix: update timeline view to show dynamic wf internals on first render

Signed-off-by: Olga Nad <[email protected]>

* fix: update tests and clean up code

Signed-off-by: Olga Nad <[email protected]>

* fix: test

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Olga Nad <[email protected]>

* fix: webmanifest missing crossorigin attribute (#566)

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>

* fix: console showing subworkflows as unknown (#570)

* fix: console showing subworkflows as unknown

Signed-off-by: Olga Nad <[email protected]>

* fix: replace comparison with lodash isEqual

Signed-off-by: Olga Nad <[email protected]>

* fix: remove checkIfObjectsAreSame

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Olga Nad <[email protected]>

* fix: Dict value loses 1 trailing character on UI Launch. (#561)

fix: dict lose trailing issue

Signed-off-by: James <[email protected]>

Signed-off-by: James <[email protected]>

* fix: launchform validation (#557)

* fix: disable launch button and show validation messaages

Signed-off-by: James <[email protected]>

* fix: code clean

Signed-off-by: James <[email protected]>

Signed-off-by: James <[email protected]>

* fix: integrate timeline and graph tabs wrappers under one component (#572)

* fix: integrate timeline and graph tabs wrappers under one component

Signed-off-by: Olga Nad <[email protected]>

* fix: details tab in graph view and clean-up

Signed-off-by: Olga Nad <[email protected]>

* fix: old unit tests

Signed-off-by: Olga Nad <[email protected]>

* fix: temp filename change

Signed-off-by: Olga Nad <[email protected]>

* fix: final filename change

Signed-off-by: Olga Nad <[email protected]>

* fix: tsconfig

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Olga Nad <[email protected]>

* chore(deps-dev): bump moment from 2.29.3 to 2.29.4 (#549)

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* added none type in union type (#577)

* added none type in union type

Signed-off-by: eugenejahn <[email protected]>

* udpated the test case

Signed-off-by: eugenejahn <[email protected]>

* fix: fixed eslint

Signed-off-by: eugenejahn <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

* fix: correctly coerce `defaultValue` when rendering LaunchPlan details (#578)

fix: correctly coerce defaultValue when rendering LaunchPlan details

Signed-off-by: Rahul Mehta <[email protected]>

Signed-off-by: Rahul Mehta <[email protected]>

* #minor: inputHelpers InputProps (#579)

fix: inputHelpers InputProps

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>

* fix: fix test of launchform (#581)

* fix: fix test of launchform

Signed-off-by: James <[email protected]>

* fix: inputHelpers tests regression

Signed-off-by: Olga Nad <[email protected]>

* fix: update tests description

Signed-off-by: Olga Nad <[email protected]>

* fix: spelling typo

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: James <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
Co-authored-by: Olga Nad <[email protected]>

* Pruning some unused packages (#583)

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>

* feat: minor change (#584)

Minor change

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>

* fix: floor seconds to int in the edge case moment returns it as float (#582)

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Olga Nad <[email protected]>

* Update Flyteidl version (#575)

Signed-off-by: Flyte-Bot <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>

* fix: add BASE_URL to dev startup, open deeply nested urls (#589)

* fix: add BASE_URL to dev startup, open deeply nested urls

Signed-off-by: Carina Ursu <[email protected]>

* fix: remove debug code

Signed-off-by: Carina Ursu <[email protected]>

* chore: empty BASE_URL handling

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>

* fix: add default disabled state for only mine filter (#585)

* fix: add default disabled state for only mine filter

Signed-off-by: Olga Nad <[email protected]>

* fix: tests

Signed-off-by: Olga Nad <[email protected]>

* fix: use api context to default filter state

Signed-off-by: Olga Nad <[email protected]>

* fix: revert test updates

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Olga Nad <[email protected]>

* Update Flyteidl version (#590)

Signed-off-by: Flyte-Bot <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>

* Launch plan ref v2 (#601)

* progress

* Fixed

* Removed debug code

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>

* fix: enable deeplinks in development (#602)

chore: enable deeplinks in development

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>

* chore: release 1.3.5 (#605)

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>

* fix: node executions stale context for relaunched executions

Signed-off-by: Olga Nad <[email protected]>

* fix: remove memoization

Signed-off-by: Olga Nad <[email protected]>

* fix: actions test

Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: eugenejahn <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Nastya <[email protected]>
Signed-off-by: Eugene Jahn <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Rahul Mehta <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
Co-authored-by: Nastya Rusina <[email protected]>
Co-authored-by: Nastya <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
Co-authored-by: Eugene Jahn <[email protected]>
Co-authored-by: apTalya <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: james-union <[email protected]>
Co-authored-by: Work <[email protected]>
Co-authored-by: Nick Müller <[email protected]>
Co-authored-by: Flyte Bot <[email protected]>
Co-authored-by: flyte-bot <[email protected]>
Co-authored-by: Rahul Mehta <[email protected]>
Co-authored-by: Jason Porter <[email protected]>
  • Loading branch information
17 people authored Oct 26, 2022
1 parent be9f643 commit 32d48c9
Show file tree
Hide file tree
Showing 12 changed files with 51 additions and 24 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
]
},
"dependencies": {
"@flyteorg/flyteidl": "https://github.com/flyteorg/flyteidl.git#feature/gate-nodes"
"@flyteorg/flyteidl": "1.2.1"
},
"devDependencies": {
"@storybook/addon-actions": "^6.4.19",
Expand Down
2 changes: 1 addition & 1 deletion packages/zapp/console/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@commitlint/cli": "^8.3.5",
"@commitlint/config-conventional": "^8.3.4",
"@date-io/moment": "1.3.9",
"@flyteorg/flyteidl": "https://github.com/flyteorg/flyteidl.git#feature/gate-nodes",
"@flyteorg/flyteidl": "1.2.1",
"@material-ui/core": "^4.0.0",
"@material-ui/icons": "^4.0.0",
"@material-ui/pickers": "^3.2.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ interface WorkflowNodeExecution extends NodeExecution {
logsByPhase?: LogsByPhase;
}

export interface ExecutionNodeViewsProps {
interface ExecutionNodeViewsProps {
execution: Execution;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { useNodeExecutionContext } from '../contextProvider/NodeExecutionDetails
import { ScaleProvider } from './Timeline/scaleContext';
import { ExecutionTabContent } from './ExecutionTabContent';

export interface ExecutionTabProps {
interface ExecutionTabProps {
tabType: string;
filteredNodeExecutions?: NodeExecution[];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { DetailsPanelContext } from './DetailsPanelContext';
import { useNodeExecutionFiltersState } from '../filters/useExecutionFiltersState';
import { nodeExecutionPhaseConstants } from '../constants';

export interface ExecutionTabContentProps {
interface ExecutionTabContentProps {
tabType: string;
filteredNodeExecutions?: NodeExecution[];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export const NodeExecutionDetailsPanelContent: React.FC<NodeExecutionDetailsProp
const commonStyles = useCommonStyles();
const styles = useStyles();
const queryClient = useQueryClient();
const detailsContext = useNodeExecutionContext();
const { getNodeExecutionDetails } = useNodeExecutionContext();
const nodeExecutionsById = useContext(NodeExecutionsByIdContext);
const { compiledWorkflowClosure } = useNodeExecutionContext();
const isGateNode = isNodeGateNode(
Expand Down Expand Up @@ -270,7 +270,7 @@ export const NodeExecutionDetailsPanelContent: React.FC<NodeExecutionDetailsProp

useEffect(() => {
let isCurrent = true;
detailsContext.getNodeExecutionDetails(nodeExecution).then((res) => {
getNodeExecutionDetails(nodeExecution).then((res) => {
if (isCurrent) {
setDetails(res);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { isMapTaskType } from 'models/Task/utils';
import { useEffect, useState } from 'react';
import { CacheStatus } from './CacheStatus';

export interface NodeExecutionCacheStatusProps {
interface NodeExecutionCacheStatusProps {
execution: NodeExecution;
/** `normal` will render an icon with description message beside it
* `iconOnly` will render just the icon with the description as a tooltip
Expand All @@ -27,12 +27,12 @@ export const NodeExecutionCacheStatus: React.FC<NodeExecutionCacheStatusProps> =
variant = 'normal',
}) => {
const taskNodeMetadata = execution.closure?.taskNodeMetadata;
const detailsContext = useNodeExecutionContext();
const { getNodeExecutionDetails } = useNodeExecutionContext();
const [nodeDetails, setNodeDetails] = useState<NodeExecutionDetails | undefined>();

useEffect(() => {
let isCurrent = true;
detailsContext.getNodeExecutionDetails(execution).then((res) => {
getNodeExecutionDetails(execution).then((res) => {
if (isCurrent) {
setNodeDetails(res);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,15 @@ export const NodeExecutionActions = ({ execution }: NodeExecutionActionsProps):
);

useEffect(() => {
let isCurrent = true;
getNodeExecutionDetails(execution).then((res) => {
setNodeExecutionDetails(res);
if (isCurrent) {
setNodeExecutionDetails(res);
}
});
return () => {
isCurrent = false;
};
});

useEffect(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { useNodeExecutionContext } from '../contextProvider/NodeExecutionDetails
import { NodeExecutionRow } from './NodeExecutionRow';
import { useNodeExecutionFiltersState } from '../filters/useExecutionFiltersState';

export interface NodeExecutionsTableProps {
interface NodeExecutionsTableProps {
initialNodes: dNode[];
filteredNodes?: dNode[];
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { fireEvent, render, waitFor } from '@testing-library/react';
import { act, fireEvent, render, waitFor } from '@testing-library/react';
import { NodeExecutionDetailsContextProvider } from 'components/Executions/contextProvider/NodeExecutionDetails';
import { mockWorkflowId } from 'mocks/data/fixtures/types';
import { QueryClient, QueryClientProvider } from 'react-query';
Expand Down Expand Up @@ -42,17 +42,25 @@ describe('Executions > Tables > NodeExecutionActions', () => {
);

it('should render rerun action, if id can be determined', async () => {
const { queryByTitle } = renderComponent({ execution, state });
await waitFor(() => queryByTitle('Rerun'));
let queryByTitle;
await act(() => {
const component = renderComponent({ execution, state });
queryByTitle = component.queryByTitle;
});
await waitFor(() => queryByTitle('View Inputs & Outputs'));

expect(queryByTitle('View Inputs & Outputs')).toBeInTheDocument();
expect(queryByTitle('Rerun')).toBeInTheDocument();
expect(queryByTitle('Resume')).not.toBeInTheDocument();
expect(queryByTitle('Rerun')).toBeInTheDocument();
});

it('should render resume action, if the status is PAUSED', async () => {
const mockExecution = { ...execution, closure: { phase: 100 } };
const { queryByTitle } = renderComponent({ execution: mockExecution, state });
let queryByTitle;
await act(() => {
const component = renderComponent({ execution: mockExecution, state });
queryByTitle = component.queryByTitle;
});
await waitFor(() => queryByTitle('Resume'));

expect(queryByTitle('View Inputs & Outputs')).toBeInTheDocument();
Expand All @@ -62,9 +70,12 @@ describe('Executions > Tables > NodeExecutionActions', () => {

it('should render ResumeForm on resume button click', async () => {
const mockExecution = { ...execution, closure: { phase: 100 } };
const { queryByTitle, getByTitle, queryByTestId } = renderComponent({
execution: mockExecution,
state,
let queryByTitle, getByTitle, queryByTestId;
await act(() => {
const component = renderComponent({ execution: mockExecution, state });
queryByTitle = component.queryByTitle;
getByTitle = component.getByTitle;
queryByTestId = component.queryByTestId;
});
await waitFor(() => queryByTitle('Resume'));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,16 @@ export function useAllTreeNodeExecutionGroupsQuery(
}
};

const key = `${nodeExecutions?.[0]?.scopedId}-${nodeExecutions?.[0]?.closure?.phase}`;
const n = nodeExecutions.length - 1;
let key = '';
if (n >= 0) {
const keyP1 = `${nodeExecutions[0]?.scopedId}-${nodeExecutions[0].closure.phase}-${nodeExecutions[0].closure?.startedAt?.nanos}`;
key = keyP1;
if (n >= 1) {
const keyP2 = `${nodeExecutions[n]?.scopedId}-${nodeExecutions[n].closure.phase}-${nodeExecutions[n].closure?.startedAt?.nanos}`;
key = keyP1 + '-' + keyP2;
}
}

return useConditionalQuery<NodeExecution[]>(
{
Expand Down
7 changes: 4 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1662,9 +1662,10 @@
minimatch "^3.1.2"
strip-json-comments "^3.1.1"

"@flyteorg/flyteidl@https://github.com/flyteorg/flyteidl.git#feature/gate-nodes":
version "0.0.0-develop"
resolved "https://github.com/flyteorg/flyteidl.git#30fed9fd8d9d99d6ca34a9023f3b33e095bb4ea5"
"@flyteorg/[email protected]":
version "1.2.1"
resolved "https://registry.yarnpkg.com/@flyteorg/flyteidl/-/flyteidl-1.2.1.tgz#124032da9db6dfabf10007c4549ba469d0b62127"
integrity sha512-NYMwCS7V0gpvSTi+lkvx8NuxvXIsLr/lcKRwdLPMbnHDcpXMq7pTRBUJk+0iicdMqm+bUJOgx7uQYUG0hxp68w==

"@gar/promisify@^1.0.1", "@gar/promisify@^1.1.3":
version "1.1.3"
Expand Down

0 comments on commit 32d48c9

Please sign in to comment.