feat(310): map task v1 visuals, supporting both old and new api #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Nastya Rusina <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 65.99% 65.99%
=======================================
Files 401 402 +1
Lines 8877 8952 +75
Branches 1543 1574 +31
=======================================
+ Hits 5858 5908 +50
- Misses 3019 3044 +25
Continue to review full report at Codecov.
|
anrusina
requested review from
olga-union,
a team,
ursucarina and
jsonporter
and removed request for
a team
anrusina
commented
Apr 7, 2022
src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx
Outdated
Show resolved
Hide resolved
olga-union
reviewed
Apr 7, 2022
src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx
Outdated
Show resolved
Hide resolved
anrusina
commented
Apr 8, 2022
Signed-off-by: Nastya Rusina <[email protected]>
flyte-bot
added a commit
that referenced
this pull request
Apr 8, 2022
# [0.49.0](http://github.com/lyft/flyteconsole/compare/v0.48.0...v0.49.0) (2022-04-08) ### Bug Fixes * **359:** fix assets folder location to simplify oneclick experience ([#360](http://github.com/lyft/flyteconsole/issues/360)) ([9d1a5f8](http://github.com/lyft/flyteconsole/commit/9d1a5f83c256e3265c0d02d41038335ddd5eb948)) ### Features * **310:** map task v1 visuals, supporting both old and new api ([#357](http://github.com/lyft/flyteconsole/issues/357)) ([4bbc71f](http://github.com/lyft/flyteconsole/commit/4bbc71f200dbf5bd36f6ace59a6d54a1cab0df6c))
|
🎉 This PR is included in version 0.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to support new MapTask structure, where individual logs are grouped by current phase status.
Type
Are all requirements met?
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/310
Complete description
Map tasks completed before Admin update have old look:
Task completed after admin Update have new look:
Added Storybook implementations:
In storybook below you can see all possible data shown. Log items rendered as lighter black text - are the ones that don't yet have logs links assigned
Signed-off-by: Nastya Rusina [email protected]