fix(359): fix assets folder location to simplify oneclick experience #360
+29
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anrusina
requested review from
a team,
ursucarina,
jsonporter and
olga-union
and removed request for
a team
anrusina
commented
Apr 7, 2022
| logo: path.resolve(__dirname, 'src/assets/favicon.png'), //'./src/assets/favicon.png', - narusina | ||
| prefix: '[fullhash:8]/' | ||
| logo: path.resolve(__dirname, 'src/assets/favicon.png'), | ||
| prefix: 'assets/', // we can add '[fullhash:8]/' to the end of the file in future |
There was a problem hiding this comment.
For now we don not add hash value to file names or to folders
ursucarina
previously approved these changes
Apr 7, 2022
olga-union
previously approved these changes
Apr 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 65.99% 65.99%
=======================================
Files 401 401
Lines 8877 8877
Branches 1543 1543
=======================================
Hits 5858 5858
Misses 3019 3019 Continue to review full report at Codecov.
|
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
force-pushed
the
narusina/one_click
branch
from
e56460a
to
ce18b9e
Compare
olga-union
approved these changes
Apr 8, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 8, 2022
# [0.49.0](http://github.com/lyft/flyteconsole/compare/v0.48.0...v0.49.0) (2022-04-08) ### Bug Fixes * **359:** fix assets folder location to simplify oneclick experience ([#360](http://github.com/lyft/flyteconsole/issues/360)) ([9d1a5f8](http://github.com/lyft/flyteconsole/commit/9d1a5f83c256e3265c0d02d41038335ddd5eb948)) ### Features * **310:** map task v1 visuals, supporting both old and new api ([#357](http://github.com/lyft/flyteconsole/issues/357)) ([4bbc71f](http://github.com/lyft/flyteconsole/commit/4bbc71f200dbf5bd36f6ace59a6d54a1cab0df6c))
|
🎉 This PR is included in version 0.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
flyte-bot
added a commit
that referenced
this pull request
Apr 8, 2022
## [0.50.2](http://github.com/lyft/flyteconsole/compare/v0.50.1...v0.50.2) (2022-04-08) ### Reverts * Revert "fix(359): fix assets folder location to simplify oneclick experience (#360)" (#363) ([7d2d252](http://github.com/lyft/flyteconsole/commit/7d2d25259b0a14f8f26e57ffb64367150efc7761)), closes [#360](http://github.com/lyft/flyteconsole/issues/360) [#363](http://github.com/lyft/flyteconsole/issues/363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Jason's fix from his POC one click PR:
https://github.com/unionai/flyteconsole/pull/1/files#diff-ec2cabc8139e814d33682814c1ba15a1056d946ab70f740c9d42ada07af42050
Type
Are all requirements met?
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/359
Signed-off-by: Nastya Rusina [email protected]