chore: pr feedback

Signed-off-by: Nastya Rusina <[email protected]>
flyteorg · Apr 8, 2022 · 27d9838 · 27d9838
1 parent 15a6081
commit 27d9838
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/components/Entities/EntityDetailsHeader.tsx b/src/components/Entities/EntityDetailsHeader.tsx
@@ -24,7 +24,7 @@ const useStyles = makeStyles((theme: Theme) => ({
     width: '100%',
   },
   headerText: {
-    margin: `0 ${theme.spacing(1)}px`,
+    margin: theme.spacing(0, 1),
   },
   headerTextContainer: {
     display: 'flex',

diff --git a/src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx b/src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx
@@ -23,7 +23,7 @@ const useStyles = makeStyles((theme) => {
       },
     },
     tabItem: {
-      margin: `0 ${theme.spacing(1)}px`,
+      margin: theme.spacing(0, 1),
     },
   };
 });

diff --git a/src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx b/src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx
@@ -35,7 +35,7 @@ interface MapTaskExecutionsListItemProps {
   showAttempts: boolean;
 }
 
-const RenderOrder: TaskExecutionPhase[] = [
+const RENDER_ORDER: TaskExecutionPhase[] = [
   TaskExecutionPhase.UNDEFINED,
   TaskExecutionPhase.INITIALIZING,
   TaskExecutionPhase.WAITING_FOR_RESOURCES,
@@ -61,7 +61,7 @@ export const MapTaskExecutionsListItem: React.FC<MapTaskExecutionsListItemProps>
 
   // Set UI elements in a proper rendering order
   const logsSections: JSX.Element[] = [];
-  for (const key of RenderOrder) {
+  for (const key of RENDER_ORDER) {
     const values = logsInfo.get(key);
     if (values) {
       logsSections.push(<MapTaskStatusInfo status={key} taskLogs={values} expanded={false} />);
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,7 @@ const useStyles = makeStyles((theme) => { @@
           },
         },
         tabItem: {
-          margin: `0 ${theme.spacing(1)}px`,
+          margin: theme.spacing(0, 1),
         },
       };
     });
@@ Expand Down @@