Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flyte][1][IDL] Binary IDL With MessagePack #5751

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

Future-Outlier
Copy link
Member

Tracking issue

#5318

Why are the changes needed?

Tell others how to Bianry IDL, MessagePack as an example.

What changes were proposed in this pull request?

Add comments.

How was this patch tested?

flyte backend: #5744
flytekit: flyteorg/flytekit#2751

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.30%. Comparing base (0eaa20e) to head (1ceb65b).
Report is 157 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5751      +/-   ##
==========================================
+ Coverage   35.42%   36.30%   +0.87%     
==========================================
  Files        1208     1305      +97     
  Lines      105156   109997    +4841     
==========================================
+ Hits        37254    39929    +2675     
- Misses      63932    65912    +1980     
- Partials     3970     4156     +186     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.62% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.26% <ø> (+0.04%) ⬆️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.88% <ø> (ø)
unittests-flytestdlib 55.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier force-pushed the binary-idl-with-message-pack-bytes-1 branch from 36ddd49 to c94c3fa Compare September 18, 2024 16:46
@Future-Outlier Future-Outlier merged commit 1502d23 into master Sep 19, 2024
50 checks passed
@Future-Outlier Future-Outlier deleted the binary-idl-with-message-pack-bytes-1 branch September 19, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants