Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flyte][1][IDL] Binary IDL With MessagePack #5751

Merged
merged 3 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions flyteidl/clients/go/assets/admin.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions flyteidl/gen/pb-es/flyteidl/core/literals_pb.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flyteidl/gen/pb-go/flyteidl/core/literals.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions flyteidl/gen/pb_rust/flyteidl.core.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flyteidl/protos/flyteidl/core/literals.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ message BlobMetadata {
// A simple byte array with a tag to help different parts of the system communicate about what is in the byte array.
// It's strongly advisable that consumers of this type define a unique tag and validate the tag before parsing the data.
message Binary {
bytes value = 1;
string tag = 2;
bytes value = 1; // Serialized data (MessagePack) for supported types like Dataclass, Pydantic BaseModel, and untyped dict.
string tag = 2; // The serialization format identifier (e.g., MessagePack). Consumers must define unique tags and validate them before deserialization.
}

// A strongly typed schema that defines the interface of data retrieved from the underlying storage medium.
Expand Down
2 changes: 1 addition & 1 deletion flytepropeller/pkg/compiler/validators/bindings.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func validateBinding(w c.WorkflowBuilder, node c.Node, nodeParam string, binding
} else if sourceType.GetMapValueType() != nil {
sourceType = sourceType.GetMapValueType()
} else if sourceType.GetStructure() != nil && sourceType.GetStructure().GetDataclassType() != nil {

// This is for retrieving the literal type of an attribute in a dataclass or Pydantic BaseModel
tmpType, exist = sourceType.GetStructure().GetDataclassType()[attr.GetStringValue()]

if !exist {
Expand Down
Loading