Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Binary IDL With MessagePack Bytes #5744

Closed
wants to merge 6 commits into from

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 13, 2024

Summary

This will be merged in separate stack PRs.

flyte backend

  1. IDL comments
  2. literal type for scalar
  3. attribute access // a lot of tests
  4. flytectl
  5. compiler compare with JSON SCHEMA if both literal type are struct

Tracking issue

#5318

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 8.62069% with 53 lines in your changes missing coverage. Please review.

Project coverage is 36.23%. Comparing base (59bf191) to head (a10290f).
Report is 171 commits behind head on master.

Files with missing lines Patch % Lines
...opeller/pkg/controller/nodes/attr_path_resolver.go 9.25% 48 Missing and 1 partial ⚠️
flytepropeller/pkg/compiler/validators/utils.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
+ Coverage   36.21%   36.23%   +0.01%     
==========================================
  Files        1303     1305       +2     
  Lines      109644   109926     +282     
==========================================
+ Hits        39710    39831     +121     
- Misses      65810    65945     +135     
- Partials     4124     4150      +26     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.56% <ø> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.66% <8.62%> (-0.09%) ⬇️
unittests-flytestdlib 55.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

case

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant