Match flytekit versions used to register and run functional tests #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5059 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 645 645
Lines 55578 55578
=======================================
Hits 32792 32792
Misses 20194 20194
Partials 2592 2592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
changed the title
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
approved these changes
Mar 15, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
…yteorg#5059) * wip - test Signed-off-by: Eduardo Apolinario <[email protected]> * Use latest flytekit to register tests Signed-off-by: Eduardo Apolinario <[email protected]> * Use python 3.12 to run tests Signed-off-by: Eduardo Apolinario <[email protected]> * Force versions of flytekit and image to match Signed-off-by: Eduardo Apolinario <[email protected]> * Use awk Signed-off-by: Eduardo Apolinario <[email protected]> * Checkout specific flytesnacks ref Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
We should use the same version of flytekit to register and run tests, thereby decreasing the chances of mismatches in expectations of commands used to run the tasks in the tests.
In this specific case, we shipped flyteorg/flytekit#2242 in version 1.12.0b0, which changed the the resolvers used in the registration of map tasks (arraynode-based and legacy). That change is present in the latest flytekit images (
ghcr.io/flyteorg/flytekit:py.3.11-latest, etc). That is the same image used in the registration of functional tests in single-binary. The issue happens when we use a different version to register those tests (because the task templates are produced during registration, and those will use the older resolvers for map task).What changes were proposed in this pull request?
Move to python 3.12 and force the image used during registration to match the same installed version of flytekit.
Also took the opportunity to implement the TODO.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link