Skip to content

Commit

Permalink
Match flytekit versions used to register and run functional tests (#5059
Browse files Browse the repository at this point in the history
)

* wip - test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use latest flytekit to register tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use python 3.12 to run tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Force versions of flytekit and image to match

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use awk

Signed-off-by: Eduardo Apolinario <[email protected]>

* Checkout specific flytesnacks ref

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario and eapolinario authored Mar 15, 2024
1 parent 642b08c commit 3100c12
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/single-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"
- uses: unionai/[email protected]
- name: Setup sandbox
run: |
Expand All @@ -181,17 +181,17 @@ jobs:
with:
repository: flyteorg/flytesnacks
path: flytesnacks
# TODO: Enable this once refactored version produces a release tag
# ref: ${{ env.FLYTESNACKS_VERSION }}
ref: ${{ env.FLYTESNACKS_VERSION }}
- name: Register specific tests
run: |
flytekit_version=$(pip show flytekit | grep -i version | awk '{ print $2 }')
while read -r line;
do
pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \
register \
--project flytesnacks \
--domain development \
--image cr.flyte.org/flyteorg/flytekit:py3.11-latest \
--image cr.flyte.org/flyteorg/flytekit:py3.12-${flytekit_version} \
--version ${{ env.FLYTESNACKS_VERSION }} \
flytesnacks/$line;
done < flytesnacks/flyte_tests.txt
Expand Down

0 comments on commit 3100c12

Please sign in to comment.