Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match flytekit versions used to register and run functional tests #5059

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Match flytekit versions used to register and run functional tests #5059

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c19113b
wip - test
eapolinario Mar 14, 2024
98e1c75
Use latest flytekit to register tests
eapolinario Mar 14, 2024
2bf4d7f
Use python 3.12 to run tests
eapolinario Mar 14, 2024
5080bf0
Force versions of flytekit and image to match
eapolinario Mar 14, 2024
c3b1ce5
Use awk
eapolinario Mar 14, 2024
ac1f57e
Checkout specific flytesnacks ref
eapolinario Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/single-binary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"
- uses: unionai/[email protected]
- name: Setup sandbox
run: |
Expand All @@ -181,17 +181,17 @@ jobs:
with:
repository: flyteorg/flytesnacks
path: flytesnacks
# TODO: Enable this once refactored version produces a release tag
# ref: ${{ env.FLYTESNACKS_VERSION }}
ref: ${{ env.FLYTESNACKS_VERSION }}
- name: Register specific tests
run: |
flytekit_version=$(pip show flytekit | grep -i version | awk '{ print $2 }')
while read -r line;
do
pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \
register \
--project flytesnacks \
--domain development \
--image cr.flyte.org/flyteorg/flytekit:py3.11-latest \
--image cr.flyte.org/flyteorg/flytekit:py3.12-${flytekit_version} \
--version ${{ env.FLYTESNACKS_VERSION }} \
flytesnacks/$line;
done < flytesnacks/flyte_tests.txt
Expand Down
Loading