Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow all origins in FlyteAdmin CORS setting for Sandbox #477

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Aug 19, 2020

No description provided.

katrogan
katrogan previously approved these changes Aug 19, 2020
@kumare3 kumare3 changed the title Allow all origins in FlyteAdmin CORS setting for Sandbox [WIP] Allow all origins in FlyteAdmin CORS setting for Sandbox Aug 19, 2020
@kumare3
Copy link
Contributor Author

kumare3 commented Aug 24, 2020

This is dependent on this change - flyteorg/flyteconsole#89

@kumare3 kumare3 changed the title [WIP] Allow all origins in FlyteAdmin CORS setting for Sandbox feat: Allow all origins in FlyteAdmin CORS setting for Sandbox Aug 25, 2020
@kumare3 kumare3 merged commit 2905b8d into master Aug 25, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
* avoid interacting with nil mutatedWfs

Signed-off-by: Babis Kiosidis <[email protected]>

* only strip crd fields from mutated wfs

Signed-off-by: Babis Kiosidis <[email protected]>

* test failure in executor

Signed-off-by: Babis Kiosidis <[email protected]>

Signed-off-by: Babis Kiosidis <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 9, 2023
* avoid interacting with nil mutatedWfs

Signed-off-by: Babis Kiosidis <[email protected]>

* only strip crd fields from mutated wfs

Signed-off-by: Babis Kiosidis <[email protected]>

* test failure in executor

Signed-off-by: Babis Kiosidis <[email protected]>

Signed-off-by: Babis Kiosidis <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants