Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow all origins in FlyteAdmin CORS setting for Sandbox #477

Merged
merged 2 commits into from
Aug 25, 2020
Merged

feat: Allow all origins in FlyteAdmin CORS setting for Sandbox #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33ce2c
Allow all origins in FlyteAdmin CORS setting for Sandbox
Aug 19, 2020
e0968e9
Updated
Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployment/eks/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,13 +708,13 @@ spec:
labels:
app: flyteconsole
app.kubernetes.io/name: flyteconsole
app.kubernetes.io/version: 0.8.0
app.kubernetes.io/version: 0.9.0
spec:
containers:
- envFrom:
- configMapRef:
name: flyte-console-config
image: docker.io/lyft/flyteconsole:v0.8.0
image: docker.io/lyft/flyteconsole:v0.9.0
name: flyteconsole
ports:
- containerPort: 8080
Expand Down
18 changes: 12 additions & 6 deletions deployment/sandbox/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,12 @@ data:
security:
secure: false
useAuth: false
allowCors: false
allowCors: true
allowedOrigins:
# Accepting all domains for Sandbox installation
- "*"
allowedHeaders:
- "Content-Type"
flyteadmin:
roleNameKey: "iam.amazonaws.com/role"
profilerPort: 10254
Expand Down Expand Up @@ -671,13 +676,14 @@ data:
refresh: 5m
kind: ConfigMap
metadata:
name: flyte-admin-config-dd2th9h4k5
name: flyte-admin-config-42k268hb6k
namespace: flyte
---
apiVersion: v1
data:
BASE_URL: /console
CONFIG_DIR: /etc/flyte/config
DISABLE_AUTH: "true"
kind: ConfigMap
metadata:
name: flyte-console-config
Expand Down Expand Up @@ -1184,7 +1190,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-dd2th9h4k5
name: flyte-admin-config-42k268hb6k
name: config-volume
---
apiVersion: apps/v1
Expand All @@ -1204,13 +1210,13 @@ spec:
labels:
app: flyteconsole
app.kubernetes.io/name: flyteconsole
app.kubernetes.io/version: 0.8.0
app.kubernetes.io/version: 0.9.0
spec:
containers:
- envFrom:
- configMapRef:
name: flyte-console-config
image: docker.io/lyft/flyteconsole:v0.8.0
image: docker.io/lyft/flyteconsole:v0.9.0
name: flyteconsole
ports:
- containerPort: 8080
Expand Down Expand Up @@ -1591,7 +1597,7 @@ spec:
name: clusterresource-template-kf62ttf64k
name: resource-templates
- configMap:
name: flyte-admin-config-dd2th9h4k5
name: flyte-admin-config-42k268hb6k
name: config-volume
schedule: '*/1 * * * *'
---
Expand Down
13 changes: 9 additions & 4 deletions deployment/test/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,12 @@ data:
security:
secure: false
useAuth: false
allowCors: false
allowCors: true
allowedOrigins:
# Accepting all domains for Sandbox installation
- "*"
allowedHeaders:
- "Content-Type"
flyteadmin:
roleNameKey: "iam.amazonaws.com/role"
profilerPort: 10254
Expand Down Expand Up @@ -509,7 +514,7 @@ data:
refresh: 5m
kind: ConfigMap
metadata:
name: flyte-admin-config-dd2th9h4k5
name: flyte-admin-config-42k268hb6k
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -805,7 +810,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-dd2th9h4k5
name: flyte-admin-config-42k268hb6k
name: config-volume
---
apiVersion: apps/v1
Expand Down Expand Up @@ -1102,7 +1107,7 @@ spec:
name: clusterresource-template-kf62ttf64k
name: resource-templates
- configMap:
name: flyte-admin-config-dd2th9h4k5
name: flyte-admin-config-42k268hb6k
name: config-volume
schedule: '*/1 * * * *'
---
Expand Down
4 changes: 2 additions & 2 deletions kustomize/base/console/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ spec:
labels:
app: flyteconsole
app.kubernetes.io/name: flyteconsole
app.kubernetes.io/version: 0.8.0
app.kubernetes.io/version: 0.9.0
spec:
volumes:
- name: shared-data
emptyDir: {}
containers:
- name: flyteconsole
image: docker.io/lyft/flyteconsole:v0.8.0
image: docker.io/lyft/flyteconsole:v0.9.0
# args: []
ports:
- containerPort: 8080
Expand Down
7 changes: 6 additions & 1 deletion kustomize/overlays/sandbox/admindeployment/flyteadmin_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ server:
security:
secure: false
useAuth: false
allowCors: false
allowCors: true
allowedOrigins:
# Accepting all domains for Sandbox installation
- "*"
allowedHeaders:
- "Content-Type"
flyteadmin:
roleNameKey: "iam.amazonaws.com/role"
profilerPort: 10254
Expand Down
12 changes: 12 additions & 0 deletions kustomize/overlays/sandbox/console/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: flyte-console-config
namespace: flyte
data:
# This determines the base url used for all console links. It must match the route specified in ingress.yaml
BASE_URL: /console
CONFIG_DIR: /etc/flyte/config
DISABLE_AUTH: "true"
# IF Port-forwardin or if Admin and Console are running on different domainsg, then this should point to the host/port of Flyteadmin
# ADMIN_API_URL: http://localhost:8089
1 change: 1 addition & 0 deletions kustomize/overlays/sandbox/console/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ bases:

patches:
- console.yaml
- config.yaml