feat: Allow all origins in FlyteAdmin CORS setting for Sandbox (#477)

flyteorg · Aug 25, 2020 · 2905b8d · 2905b8d
1 parent 55c416e
commit 2905b8d
Show file tree

Hide file tree

Showing 7 changed files with 44 additions and 15 deletions.
diff --git a/deployment/eks/flyte_generated.yaml b/deployment/eks/flyte_generated.yaml
@@ -708,13 +708,13 @@ spec:
       labels:
         app: flyteconsole
         app.kubernetes.io/name: flyteconsole
-        app.kubernetes.io/version: 0.8.0
+        app.kubernetes.io/version: 0.9.0
     spec:
       containers:
       - envFrom:
         - configMapRef:
             name: flyte-console-config
-        image: docker.io/lyft/flyteconsole:v0.8.0
+        image: docker.io/lyft/flyteconsole:v0.9.0
         name: flyteconsole
         ports:
         - containerPort: 8080

diff --git a/deployment/sandbox/flyte_generated.yaml b/deployment/sandbox/flyte_generated.yaml
@@ -603,7 +603,12 @@ data:
       security:
         secure: false
         useAuth: false
-        allowCors: false
+        allowCors: true
+        allowedOrigins:
+          # Accepting all domains for Sandbox installation
+          - "*"
+        allowedHeaders:
+          - "Content-Type"
     flyteadmin:
       roleNameKey: "iam.amazonaws.com/role"
       profilerPort: 10254
@@ -671,13 +676,14 @@ data:
       refresh: 5m
 kind: ConfigMap
 metadata:
-  name: flyte-admin-config-dd2th9h4k5
+  name: flyte-admin-config-42k268hb6k
   namespace: flyte
 ---
 apiVersion: v1
 data:
   BASE_URL: /console
   CONFIG_DIR: /etc/flyte/config
+  DISABLE_AUTH: "true"
 kind: ConfigMap
 metadata:
   name: flyte-console-config
@@ -1184,7 +1190,7 @@ spec:
       - emptyDir: {}
         name: shared-data
       - configMap:
-          name: flyte-admin-config-dd2th9h4k5
+          name: flyte-admin-config-42k268hb6k
         name: config-volume
 ---
 apiVersion: apps/v1
@@ -1204,13 +1210,13 @@ spec:
       labels:
         app: flyteconsole
         app.kubernetes.io/name: flyteconsole
-        app.kubernetes.io/version: 0.8.0
+        app.kubernetes.io/version: 0.9.0
     spec:
       containers:
       - envFrom:
         - configMapRef:
             name: flyte-console-config
-        image: docker.io/lyft/flyteconsole:v0.8.0
+        image: docker.io/lyft/flyteconsole:v0.9.0
         name: flyteconsole
         ports:
         - containerPort: 8080
@@ -1591,7 +1597,7 @@ spec:
               name: clusterresource-template-kf62ttf64k
             name: resource-templates
           - configMap:
-              name: flyte-admin-config-dd2th9h4k5
+              name: flyte-admin-config-42k268hb6k
             name: config-volume
   schedule: '*/1 * * * *'
 ---

diff --git a/deployment/test/flyte_generated.yaml b/deployment/test/flyte_generated.yaml
@@ -441,7 +441,12 @@ data:
       security:
         secure: false
         useAuth: false
-        allowCors: false
+        allowCors: true
+        allowedOrigins:
+          # Accepting all domains for Sandbox installation
+          - "*"
+        allowedHeaders:
+          - "Content-Type"
     flyteadmin:
       roleNameKey: "iam.amazonaws.com/role"
       profilerPort: 10254
@@ -509,7 +514,7 @@ data:
       refresh: 5m
 kind: ConfigMap
 metadata:
-  name: flyte-admin-config-dd2th9h4k5
+  name: flyte-admin-config-42k268hb6k
   namespace: flyte
 ---
 apiVersion: v1
@@ -805,7 +810,7 @@ spec:
       - emptyDir: {}
         name: shared-data
       - configMap:
-          name: flyte-admin-config-dd2th9h4k5
+          name: flyte-admin-config-42k268hb6k
         name: config-volume
 ---
 apiVersion: apps/v1
@@ -1102,7 +1107,7 @@ spec:
               name: clusterresource-template-kf62ttf64k
             name: resource-templates
           - configMap:
-              name: flyte-admin-config-dd2th9h4k5
+              name: flyte-admin-config-42k268hb6k
             name: config-volume
   schedule: '*/1 * * * *'
 ---

diff --git a/kustomize/base/console/deployment.yaml b/kustomize/base/console/deployment.yaml
@@ -16,14 +16,14 @@ spec:
       labels:
         app: flyteconsole
         app.kubernetes.io/name: flyteconsole
-        app.kubernetes.io/version: 0.8.0
+        app.kubernetes.io/version: 0.9.0
     spec:
       volumes:
       - name: shared-data
         emptyDir: {}
       containers:
       - name: flyteconsole
-        image: docker.io/lyft/flyteconsole:v0.8.0
+        image: docker.io/lyft/flyteconsole:v0.9.0
         # args: []
         ports:
         - containerPort: 8080

diff --git a/kustomize/overlays/sandbox/admindeployment/flyteadmin_config.yaml b/kustomize/overlays/sandbox/admindeployment/flyteadmin_config.yaml
@@ -7,7 +7,12 @@ server:
   security:
     secure: false
     useAuth: false
-    allowCors: false
+    allowCors: true
+    allowedOrigins:
+      # Accepting all domains for Sandbox installation
+      - "*"
+    allowedHeaders:
+      - "Content-Type"
 flyteadmin:
   roleNameKey: "iam.amazonaws.com/role"
   profilerPort: 10254

diff --git a/kustomize/overlays/sandbox/console/config.yaml b/kustomize/overlays/sandbox/console/config.yaml
@@ -0,0 +1,12 @@
+kind: ConfigMap
+apiVersion: v1
+metadata:
+  name: flyte-console-config
+  namespace: flyte
+data:
+  # This determines the base url used for all console links. It must match the route specified in ingress.yaml
+  BASE_URL: /console
+  CONFIG_DIR: /etc/flyte/config
+  DISABLE_AUTH: "true"
+  # IF Port-forwardin or if Admin and Console are running on different domainsg, then this should point to the host/port of Flyteadmin
+  # ADMIN_API_URL: http://localhost:8089
diff --git a/kustomize/overlays/sandbox/console/kustomization.yaml b/kustomize/overlays/sandbox/console/kustomization.yaml
@@ -3,3 +3,4 @@ bases:
 
 patches:
 - console.yaml
+- config.yaml
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,3 +3,4 @@ bases:

		patches:
		- console.yaml
		- config.yaml