-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single binary config #3808
Fix single binary config #3808
Conversation
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
@@ -7,7 +7,7 @@ | |||
# flyte start --config flyte_local.yaml | |||
propeller: | |||
rawoutput-prefix: "s3://my-s3-bucket/test/" | |||
kube-config: "$HOME/.flyte/k3s/k3s.yaml" | |||
kube-config: "$HOME/.flyte/sandbox/kubeconfig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to how the current flytectl works: https://github.com/flyteorg/flytectl/blob/0cb2bfaf436a09d58c1ae9c1389eacb6eab8a856/pkg/docker/docker_util.go#L30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it this variable or SandboxKubeconfig that's used in flytectl demo
? Let's keep whatever is used for demo
not sandbox
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also used for flytectl demo
.
startDemoCluster -> sandbox.StartDemoCluster -> StartCluster -> UpdateLocalKubeContext.
UpdateLocalKubeContext copies the kubeconfig to $HOME/.flyte/sandbox/kubeconfig
flyteadmin: | ||
runScheduler: false | ||
database: | ||
postgres: | ||
port: 30089 | ||
port: 30001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running kubectl get svc -A
:
flyte flyte-sandbox-postgresql NodePort 10.43.143.68 <none> 5432:30001/TCP 2m4s
@@ -45,7 +42,7 @@ storage: | |||
auth-type: accesskey | |||
secret-key: miniostorage | |||
disable-ssl: true | |||
endpoint: "http://localhost:30084" | |||
endpoint: "http://localhost:30002" | |||
region: my-region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running kubectl get svc -A
:
flyte flyte-sandbox-minio NodePort 10.43.93.113 <none> 9000:30002/TCP,9001:32697/TCP 2m4s
FYI @ByronHsu |
Signed-off-by: Yicheng-Lu-llll <[email protected]>
I’ve been using this one: https://github.com/flyteorg/flyte/blob/master/flyte-single-binary-local.yaml Perhaps we can consolidate and clean up? |
@jeevb I didn't notice the flyte-single-binary-local.yaml until you told me how to solve the webhook issues. In this case, do you mind I just remove flyte_local.yaml in this PR since it does not fit |
It might still be valid for the legacy sandbox. We do plan on deprecating it , and we can clean it up then? |
Describe your changes
The existing flyte_local.yaml configuration file has fallen out of date, causing issues when running single binaries. The standard process ideally looks like this:
This PR introduces necessary updates to the flyte_local.yaml configuration file.
Checks
Able to run the task
Able to see the deck:
Able to see the kubernetes logs: