Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single binary config #3808

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Fix single binary config #3808

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b767211
Update flyte_local.yaml
Yicheng-Lu-llll Jun 26, 2023
3791737
Update flyte_local.yaml
Yicheng-Lu-llll Jun 26, 2023
6b65ba3
Update flyte_local.yaml
Yicheng-Lu-llll Jun 26, 2023
8fde4a1
Update flyte_local.yaml
Yicheng-Lu-llll Jun 26, 2023
0bfa8db
Update flyte_local.yaml
Yicheng-Lu-llll Jun 26, 2023
d39c39d
Update flyte_local.yaml
Yicheng-Lu-llll Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions flyte_local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# flyte start --config flyte_local.yaml
propeller:
rawoutput-prefix: "s3://my-s3-bucket/test/"
kube-config: "$HOME/.flyte/k3s/k3s.yaml"
kube-config: "$HOME/.flyte/sandbox/kubeconfig"
Copy link
Member Author

@Yicheng-Lu-llll Yicheng-Lu-llll Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to how the current flytectl works: https://github.com/flyteorg/flytectl/blob/0cb2bfaf436a09d58c1ae9c1389eacb6eab8a856/pkg/docker/docker_util.go#L30

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it this variable or SandboxKubeconfig that's used in flytectl demo? Let's keep whatever is used for demo not sandbox.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also used for flytectl demo.

startDemoCluster -> sandbox.StartDemoCluster -> StartCluster -> UpdateLocalKubeContext.

UpdateLocalKubeContext copies the kubeconfig to $HOME/.flyte/sandbox/kubeconfig

create-flyteworkflow-crd: true
webhook:
certDir: /tmp/k8s-webhook-server/serving-certs
Expand All @@ -24,17 +24,14 @@ tasks:
- container: container
- container_array: K8S-ARRAY
server:
kube-config: "$HOME/.flyte/k3s/k3s.yaml"
httpPort: 30080
serviceHttpEndpoint: http://localhost:30080/
grpc:
port: 30081
kube-config: "$HOME/.flyte/sandbox/kubeconfig"
flyteadmin:
runScheduler: false
database:
postgres:
port: 30089
port: 30001
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running kubectl get svc -A :

flyte         flyte-sandbox-postgresql             NodePort    10.43.143.68    <none>        5432:30001/TCP                  2m4s

username: postgres
password: postgres
host: localhost
dbname: flyteadmin
options: "sslmode=disable"
Expand All @@ -45,7 +42,7 @@ storage:
auth-type: accesskey
secret-key: miniostorage
disable-ssl: true
endpoint: "http://localhost:30084"
endpoint: "http://localhost:30002"
region: my-region
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running kubectl get svc -A :

flyte         flyte-sandbox-minio                  NodePort    10.43.93.113    <none>        9000:30002/TCP,9001:32697/TCP   2m4s

cache:
max_size_mbs: 10
Expand All @@ -55,7 +52,7 @@ Logger:
show-source: true
level: 5
admin:
endpoint: localhost:30081
endpoint: localhost:8089
insecure: true
plugins:
# All k8s plugins default configuration
Expand All @@ -64,13 +61,13 @@ plugins:
default-env-vars:
- AWS_METADATA_SERVICE_TIMEOUT: 5
- AWS_METADATA_SERVICE_NUM_ATTEMPTS: 20
- FLYTE_AWS_ENDPOINT: "http://minio.flyte:9000"
- FLYTE_AWS_ENDPOINT: "http://flyte-sandbox-minio.flyte:9000"
- FLYTE_AWS_ACCESS_KEY_ID: minio
- FLYTE_AWS_SECRET_ACCESS_KEY: miniostorage
# Logging configuration
logs:
kubernetes-enabled: true
kubernetes-url: "http://localhost:30082"
kubernetes-template-uri: http://localhost:30080/kubernetes-dashboard/#/log/{{.namespace }}/{{ .podName }}/pod?namespace={{ .namespace }}
cluster_resources:
refreshInterval: 5m
templatePath: "/etc/flyte/clusterresource/templates"
Expand Down Expand Up @@ -110,4 +107,4 @@ task_resources:
catalog-cache:
endpoint: localhost:8081
insecure: true
type: datacatalog
type: datacatalog