-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development Environment Setup Guide for Flyte Components #3811
Conversation
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Thank you @Yicheng-Lu-llll, this is great! I remember struggling a lot to get a first version of a development setup as well! Should we merge this with the existing guide to avoid duplication? |
Sure, Will merge with the existing guide! |
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
I'm following this guide to set up a local dev environment. Had to run with /bin/sh: 1: go: not found
make: *** [Makefile:21: compile] Error 127 |
Hi @gpgn, it appears that the Go isn't included in your |
It was in my PATH, but not for the root user. Using Now running into an issue where it can't find {"json":{"src":"start.go:185"},"level":"panic","msg":"Failed to start Propeller, err: mkdir $HOME/.flyte/webhook-certs: no such file or directory","ts":"2023-06-30T15:29:15+02:00"} Raised it here: https://flyte-org.slack.com/archives/CP2HDHKE1/p1688129196715809 |
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Thanks so much for breaking this down. Left a few comments to help clarify a few points and hopefully generalize this a little.
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
This is amazing, @Yicheng-Lu-llll! Really appreciate you taking the time to document the setup of the development environment. |
@hamersaw, can we merge this? |
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Hi @samhita-alla, I've reviewed and rerun the code again, confirming that it operates without any errors. |
Approved by me! Was hoping to have a few more eyes on this from flytekit / flyteconsole contributors. But this is a great improvement over what we currently have (or better said "don't have"). Thanks @Yicheng-Lu-llll . |
Kevin approved the changes already. Will merge the PR. |
Describe your changes
Considering the rapid development and updates in Flyte's components, including flyteidl, flyteadmin, flyteplugins, flytepropeller, flytekit, and flyteconsole, existing guides may not fully reflect the current state of the project. This PR introduces a comprehensive Development guide for new contributors to Flyte.
The guide provides a step-by-step approach to setting up a local development environment for nearly all Flyte components, namely flyteidl, flyteadmin, flyteplugins, flytepropeller, flytekit, and flyteconsole.
Many in the open-source community might be eager to contribute but find the initial setup process a daunting hurdle. I too struggled with the setup when I first started contributing (many thanks to Kevin Su for all his help!). To break down these barriers and make the contribution process more accessible, I've created this guide.
Feedback and suggestions are highly appreciated!!!!!!
Check all the applicable boxes
Screenshots
Note to reviewers