Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When Memory/CPU/Storage/GPU limits are over the platform prescribed limits, Flyteadmin error is not descriptive #512

Closed
1 of 13 tasks
kumare3 opened this issue Sep 16, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Sep 16, 2020

Describe the bug
FlyteAdmin Error should clearly state what the problem was and potential remediation. For example, if the user requests for cpu limit that is over the platform prescribed limits then the error should state so and also provide actual limit currently set in the platform.

If parsing of the CPU limit fails then the error should be more descriptive

E.g error recived

	details : "Type CPU for [resource_type:TASK project:"flytesnacks" domain:"development" name:"demo.house_price_predictor.generate_and_split_data" version:"6755f982790bcf96a00229ac7a9981235c4554a2" ] cannot set default > platform limit"

Reason: "200Mi" was not being parsed correctly

Expected behavior
Better error message when request is more than the limit
e.g

Requested CPU [x] is greater than current maximum set in the platform configuration [y]. Please contact Flyte Admins to change these limits or consult the configuration

If parsing fails

Parsing of CPU request failed - reason 'x'. Please follow K8s conventions for resources https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 16, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jun 7, 2021
@kumare3 kumare3 added this to the 0.15.0 milestone Jun 7, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Jun 7, 2021

@katrogan this sounds like a low hanging fruit

@EngHabu EngHabu modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
@EngHabu EngHabu modified the milestones: 0.17.0, 0.18.0 Aug 31, 2021
@pmahindrakar-oss pmahindrakar-oss self-assigned this Sep 7, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
…yteorg#512)

* added random print statements

Signed-off-by: Dan Rammer <[email protected]>

* random print statement

Signed-off-by: Dan Rammer <[email protected]>

* infering gate node approve condition input and output variables from upstream nodes

Signed-off-by: Dan Rammer <[email protected]>

* removed print statements

Signed-off-by: Dan Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
…yteorg#512)

* added random print statements

Signed-off-by: Dan Rammer <[email protected]>

* random print statement

Signed-off-by: Dan Rammer <[email protected]>

* infering gate node approve condition input and output variables from upstream nodes

Signed-off-by: Dan Rammer <[email protected]>

* removed print statements

Signed-off-by: Dan Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants