Fix gate node approve condition node interface binding validation (fl…

…yteorg#512) * added random print statements Signed-off-by: Dan Rammer <[email protected]> * random print statement Signed-off-by: Dan Rammer <[email protected]> * infering gate node approve condition input and output variables from upstream nodes Signed-off-by: Dan Rammer <[email protected]> * removed print statements Signed-off-by: Dan Rammer <[email protected]> * fixed unit tests Signed-off-by: Dan Rammer <[email protected]> Signed-off-by: Dan Rammer <[email protected]>
eapolinario · Jan 3, 2023 · 437fe5d · 437fe5d
1 parent 50f1aa4
commit 437fe5d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/flytepropeller/pkg/compiler/validators/interface.go b/flytepropeller/pkg/compiler/validators/interface.go
@@ -121,9 +121,14 @@ func ValidateUnderlyingInterface(w c.WorkflowBuilder, node c.NodeBuilder, errs e
 	case *core.Node_GateNode:
 		gateNode := node.GetGateNode()
 		if approve := gateNode.GetApprove(); approve != nil {
+			// discover inputs / outputs from upstream bindings. output variable are identical to inputs
+			// because evaluating the approve condition copies the input LiteralMap directly to outputs.
+			inputVarsFromBindings, _ := ValidateBindings(w, node, node.GetInputs(), &core.VariableMap{Variables: map[string]*core.Variable{}},
+				false, c.EdgeDirectionUpstream, errs.NewScope())
+
 			iface = &core.TypedInterface{
-				Inputs:  &core.VariableMap{Variables: map[string]*core.Variable{}},
-				Outputs: &core.VariableMap{Variables: map[string]*core.Variable{}},
+				Inputs:  inputVarsFromBindings,
+				Outputs: inputVarsFromBindings,
 			}
 		} else if signal := gateNode.GetSignal(); signal != nil {
 			if signal.GetType() == nil {

diff --git a/flytepropeller/pkg/compiler/validators/interface_test.go b/flytepropeller/pkg/compiler/validators/interface_test.go
@@ -301,6 +301,7 @@ func TestValidateUnderlyingInterface(t *testing.T) {
 				},
 			})
 			nodeBuilder.OnGetInterface().Return(nil)
+			nodeBuilder.OnGetInputs().Return(nil)
 
 			nodeBuilder.On("GetGateNode").Return(gateNode)
 			nodeBuilder.On("GetId").Return("node_1")