Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix the messaging for resource configuration #251

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: Prafulla Mahindrakar [email protected]

TL;DR

Fix the messaging for task resource configurations.

Eg :
Messages on parsing error for the resource

Parsing of CPU request failed for value 200Q - reason  quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'. Please follow K8s conventions for resources https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/

In case of values going over platform limits

Requested CPU limit [1536Mi] is greater than current limit set in the platform configuration [1Gi]. Please contact Flyte Admins to change these limits or consult the configuration

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#512

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Prafulla Mahindrakar <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #251 (5096ba4) into master (5c86bbe) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   57.47%   57.53%   +0.05%     
==========================================
  Files         141      141              
  Lines       10481    10490       +9     
==========================================
+ Hits         6024     6035      +11     
+ Misses       3787     3786       -1     
+ Partials      670      669       -1     
Flag Coverage Δ
unittests 56.33% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/validation/task_validator.go 83.33% <100.00%> (+2.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c86bbe...5096ba4. Read the comment docs.

@pmahindrakar-oss pmahindrakar-oss merged commit 0c24486 into master Sep 8, 2021
@pmahindrakar-oss pmahindrakar-oss deleted the pmahindrakar/512 branch September 8, 2021 04:13
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants