Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add command metadata so we can pass in more stuff for Hive Queries #492

Closed
13 tasks
akashkatipally opened this issue Sep 1, 2020 · 1 comment
Closed
13 tasks
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@akashkatipally
Copy link

The idea for this is to have a metadata information so that I can pass it along to hive queries.

Motivation: Why do you think this is important?
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] OR why this would be a cool addition OR which usecases could this unblock.

Goal: What should the final outcome look like, ideally?
A clear and concise description of what you want to happen or achieve.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte

@akashkatipally akashkatipally added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Sep 1, 2020
@akashkatipally
Copy link
Author

@wild-endeavor wild-endeavor added this to the 0.8.0 milestone Sep 2, 2020
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 2, 2020
@anandswaminathan anandswaminathan modified the milestones: 0.8.0, 0.9.0 Sep 30, 2020
@kumare3 kumare3 closed this as completed Nov 4, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server

Signed-off-by: Daniel Rammer <[email protected]>

* and now in the webhook

Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* Update config.go

Set the default values to 0

Signed-off-by: LN <[email protected]>
Signed-off-by: Ln11211 <[email protected]>

* disable k8s controller-runtime manager metrics server (flyteorg#492)

* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server

Signed-off-by: Daniel Rammer <[email protected]>

* and now in the webhook

Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Ln11211 <[email protected]>

* fix: Add servicename in certs (flyteorg#491)

Before:
A hardcoded string was used for setting the secret namespace

After:
The value for the secret namespace for settings is grabbed dynamically.

Signed-off-by: Francisco J. Solis <[email protected]>

Signed-off-by: Francisco J. Solis <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
Signed-off-by: Ln11211 <[email protected]>

* Update config.go

Removed DefaultDeadlines

Signed-off-by: Ln11211 <[email protected]>

Signed-off-by: LN <[email protected]>
Signed-off-by: Ln11211 <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Francisco J. Solis <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
Co-authored-by: Francisco J. Solis <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
eapolinario added a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* Replace raw containers example

Signed-off-by: Eduardo Apolinario <[email protected]>

* rename workflow file to raw_container.py

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove unnecessary files

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add makefile

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add panel

Signed-off-by: Eduardo Apolinario <[email protected]>

* Test literalinclude outside panel

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix path

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo

Signed-off-by: Eduardo Apolinario <[email protected]>

* Pass a different path to literalinclude

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add caveats section and fix references to each panel.

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove extraneous literalinclude

Signed-off-by: Eduardo Apolinario <[email protected]>

* Review feedback

Signed-off-by: Eduardo Apolinario <[email protected]>

* De-indent literalinclude

Signed-off-by: Eduardo Apolinario <[email protected]>

* Lint - black

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server

Signed-off-by: Daniel Rammer <[email protected]>

* and now in the webhook

Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* Update config.go

Set the default values to 0

Signed-off-by: LN <[email protected]>
Signed-off-by: Ln11211 <[email protected]>

* disable k8s controller-runtime manager metrics server (flyteorg#492)

* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server

Signed-off-by: Daniel Rammer <[email protected]>

* and now in the webhook

Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Ln11211 <[email protected]>

* fix: Add servicename in certs (flyteorg#491)

Before:
A hardcoded string was used for setting the secret namespace

After:
The value for the secret namespace for settings is grabbed dynamically.

Signed-off-by: Francisco J. Solis <[email protected]>

Signed-off-by: Francisco J. Solis <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
Signed-off-by: Ln11211 <[email protected]>

* Update config.go

Removed DefaultDeadlines

Signed-off-by: Ln11211 <[email protected]>

Signed-off-by: LN <[email protected]>
Signed-off-by: Ln11211 <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Francisco J. Solis <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
Co-authored-by: Francisco J. Solis <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants