[core-Feature] Set deadlines to zero (flyteorg#493)

* Update config.go Set the default values to 0 Signed-off-by: LN <[email protected]> Signed-off-by: Ln11211 <[email protected]> * disable k8s controller-runtime manager metrics server (flyteorg#492) * setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer <[email protected]> * and now in the webhook Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]> * fix: Add servicename in certs (flyteorg#491) Before: A hardcoded string was used for setting the secret namespace After: The value for the secret namespace for settings is grabbed dynamically. Signed-off-by: Francisco J. Solis <[email protected]> Signed-off-by: Francisco J. Solis <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]> * Update config.go Removed DefaultDeadlines Signed-off-by: Ln11211 <[email protected]> Signed-off-by: LN <[email protected]> Signed-off-by: Ln11211 <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Francisco J. Solis <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Co-authored-by: Francisco J. Solis <[email protected]>
eapolinario · Oct 24, 2022 · b1b1ae7 · b1b1ae7
1 parent 7ffb502
commit b1b1ae7
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/pkg/controller/config/config.go b/pkg/controller/config/config.go
@@ -90,11 +90,6 @@ var (
 			RetryPeriod:   config.Duration{Duration: time.Second * 2},
 		},
 		NodeConfig: NodeConfig{
-			DefaultDeadlines: DefaultDeadlines{
-				DefaultNodeExecutionDeadline:  config.Duration{Duration: time.Hour * 48},
-				DefaultNodeActiveDeadline:     config.Duration{Duration: time.Hour * 48},
-				DefaultWorkflowActiveDeadline: config.Duration{Duration: time.Hour * 72},
-			},
 			MaxNodeRetriesOnSystemFailures: 3,
 			InterruptibleFailureThreshold:  1,
 		},