disable k8s controller-runtime manager metrics server (flyteorg#492)

* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer <[email protected]> * and now in the webhook Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
eapolinario · Oct 11, 2022 · 20129fa · 20129fa
1 parent 7d6d09d
commit 20129fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/flytepropeller/cmd/controller/cmd/root.go b/flytepropeller/cmd/controller/cmd/root.go
@@ -131,6 +131,7 @@ func executeRootCmd(baseCtx context.Context, cfg *config2.Config) error {
 		NewClient: func(cache cache.Cache, config *rest.Config, options client.Options, uncachedObjects ...client.Object) (client.Client, error) {
 			return executors.NewFallbackClientBuilder(propellerScope.NewSubScope("kube")).Build(cache, config, options)
 		},
+		MetricsBindAddress: "0",
 	}
 
 	mgr, err := controller.CreateControllerManager(ctx, cfg, options)

diff --git a/flytepropeller/cmd/controller/cmd/webhook.go b/flytepropeller/cmd/controller/cmd/webhook.go
@@ -110,8 +110,9 @@ func runWebhook(origContext context.Context, propellerCfg *config.Config, cfg *w
 		NewClient: func(cache cache.Cache, config *rest.Config, options client.Options, uncachedObjects ...client.Object) (client.Client, error) {
 			return executors.NewFallbackClientBuilder(webhookScope).Build(cache, config, options)
 		},
-		CertDir: cfg.CertDir,
-		Port:    cfg.ListenPort,
+		CertDir:            cfg.CertDir,
+		Port:               cfg.ListenPort,
+		MetricsBindAddress: "0",
 	}
 
 	mgr, err := controller.CreateControllerManager(ctx, propellerCfg, options)