Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Matchable Resources should be configurable through flyte-cli #335

Closed
1 of 13 tasks
katrogan opened this issue Jun 1, 2020 · 0 comments
Closed
1 of 13 tasks

[Feature] Matchable Resources should be configurable through flyte-cli #335

katrogan opened this issue Jun 1, 2020 · 0 comments
Assignees
@katrogan
Labels
enhancement New feature or request

Comments

@katrogan
Copy link
Contributor

katrogan commented Jun 1, 2020 •
edited
Loading

Motivation: Why do you think this is important?
Currently setting overridable matchable resources (task requests & limits, cluster resources, execution queues, etc) requires configuring the json for a post request which can be cumbersome - especially when auth is enabled. It would be ideal to manage to the resources through flyte-cli much like registering a project, etc.

Goal: What should the final outcome look like, ideally?
It should be easy and simple to update a dynamic matchable resource.

Describe alternatives you've considered
The current method of figuring out and formatting post requests works but it's annoying.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline

Additional context

Is this a blocker for you to adopt Flyte
no
@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jun 1, 2020
@katrogan katrogan self-assigned this Jun 1, 2020
@katrogan katrogan mentioned this issue Jun 1, 2020
Merged
8 tasks
@katrogan katrogan removed the untriaged This issues has not yet been looked at by the Maintainers label Jun 3, 2020
@katrogan katrogan closed this as completed Jun 8, 2020
@olga-union olga-union mentioned this issue Apr 7, 2022
Merged
8 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot @samhita-alla
Update documentation (flyteorg#335)
2c274d1 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: samhita-alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@ByronHsu
Inject container resource during BuildRawContainer (flyteorg#335)
a3f7334 
* Inject container resource during BuildRawContainer

Signed-off-by: byhsu <[email protected]>

* address comment

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@ByronHsu
Inject container resource during BuildRawContainer (flyteorg#335)
d787873 
* Inject container resource during BuildRawContainer

Signed-off-by: byhsu <[email protected]>

* address comment

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@flyte-bot @samhita-alla
Update documentation (flyteorg#335)
3989ec8 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: samhita-alla <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@flyte-bot @samhita-alla @austin362667
Update documentation (flyteorg#335)
c85a099 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: samhita-alla <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@flyte-bot @samhita-alla @robert-ulbrich-mercedes-benz
Update documentation (flyteorg#335)
321a6f5 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: samhita-alla <[email protected]>
troychiu pushed a commit that referenced this issue Jul 8, 2024
@pingsutw
fix(ray): Use default svc account if not set in task metadata (#335)
8db73eb 
## Overview
The default service account is not being used if autoscale is enabled in the ray task.

## Test Plan
```python
config = RayJobConfig(
    worker_node_config=[WorkerNodeConfig(group_name="test_group", replicas=3, min_replicas=0, max_replicas=10)],
    runtime_env={"pip": ["numpy"]},
    enable_autoscaling=True,
    shutdown_after_job_finishes=True,
    ttl_seconds_after_finished=20,
)
```

## Rollout Plan (if applicable)
staging -> canary -> production

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed to OSS

## Issue
https://linear.app/unionai/issue/DX-791/use-default-svc-account-if-not-set-in-task-metadata
Customer Issue:
https://app.usepylon.com/issues?conversationID=df7bf253-beba-4c3f-9f97-5fc68daddab2

## Checklist
* [x] Added tests
* [x] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katrogan